[Windows] Use default expansion for _colcon_python_executable#222
Merged
dirk-thomas merged 1 commit intocolcon:masterfrom Sep 6, 2019
Merged
[Windows] Use default expansion for _colcon_python_executable#222dirk-thomas merged 1 commit intocolcon:masterfrom
dirk-thomas merged 1 commit intocolcon:masterfrom
Conversation
It seems to be a regression after colcon#209, where it removed enabledelayedexpansion but forget to change the delay expansion usage back.
Contributor
Author
|
cc @dirk-thomas |
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
=======================================
Coverage 77.42% 77.42%
=======================================
Files 54 54
Lines 3109 3109
Branches 512 512
=======================================
Hits 2407 2407
Misses 675 675
Partials 27 27Continue to review full report at Codecov.
|
Member
|
Thank you for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems to be a regression after #209, where it removed
enabledelayedexpansionfor_colcon_run_ordered_commandsbut forgot to revert the delay expansion usage. As a result, whenever the generatedlocal_setup.batruns, it throws outerror: unable to find python executableeven the Python executable exists.