Skip to content

Conversation

@mafredri
Copy link
Member

@mafredri mafredri commented Oct 9, 2025

This change updates the task_workspace_apps table structure for
improved linking to workspace builds and adds queries to manage tasks
and a view to expose task status.

Updates coder/internal#948
Supersedes #20212
Supersedes #19773

Copy link
Member Author

mafredri commented Oct 9, 2025

@mafredri mafredri changed the base branch from mafredri/feat-coderd-tasks-data-model-split4 to graphite-base/20235 October 9, 2025 10:40
@mafredri mafredri marked this pull request as ready for review October 9, 2025 10:41
agentState: database.WorkspaceAgentLifecycleStateReady,
appHealths: []database.WorkspaceAppHealth{database.WorkspaceAppHealthHealthy, database.WorkspaceAppHealthHealthy},
expectedStatus: database.TaskStatusActive,
description: "Running job with ready agent and multiple healthy apps should be active",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One healthy and one unhealthy app will be error, correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, looks like I've missed the removal of a multi-app tests. We don't care about non-task app health so they're pointless. I'll make the second one unhealthy though and that way we test that health is still OK for task.

@mafredri mafredri force-pushed the mafredri/feat-coderd-tasks-data-model-split4_split branch from a05d8dc to f805f37 Compare October 9, 2025 12:58
@mafredri mafredri force-pushed the graphite-base/20235 branch from 38e1300 to e9c6164 Compare October 9, 2025 12:58
@mafredri mafredri changed the base branch from graphite-base/20235 to mafredri/feat-coderd-tasks-data-model-split4 October 9, 2025 12:58
@mafredri mafredri changed the base branch from mafredri/feat-coderd-tasks-data-model-split4 to graphite-base/20235 October 9, 2025 13:40
@mafredri mafredri force-pushed the graphite-base/20235 branch from e9c6164 to a98abac Compare October 13, 2025 08:47
@mafredri mafredri force-pushed the mafredri/feat-coderd-tasks-data-model-split4_split branch from f805f37 to 2bcc488 Compare October 13, 2025 08:47
@mafredri mafredri changed the base branch from graphite-base/20235 to mafredri/feat-coderd-tasks-data-model-split4 October 13, 2025 08:48
@mafredri mafredri changed the base branch from mafredri/feat-coderd-tasks-data-model-split4 to graphite-base/20235 October 13, 2025 09:02
This change updates the `task_workspace_apps` table structure for
improved linking to workspace builds and adds queries to manage tasks
and a view to expose task status.

Updates coder/internal#948
Supersedes #20212
Supersedes #19773
@mafredri mafredri force-pushed the mafredri/feat-coderd-tasks-data-model-split4_split branch from 2bcc488 to b3c188e Compare October 13, 2025 09:03
@mafredri mafredri force-pushed the graphite-base/20235 branch from a98abac to 299a54a Compare October 13, 2025 09:03
@graphite-app graphite-app bot changed the base branch from graphite-base/20235 to main October 13, 2025 09:04
@graphite-app
Copy link

graphite-app bot commented Oct 13, 2025

Merge activity

  • Oct 13, 9:04 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Oct 13, 9:25 AM UTC: @mafredri merged this pull request with Graphite.

@mafredri mafredri merged commit 952c69f into main Oct 13, 2025
30 checks passed
@mafredri mafredri deleted the mafredri/feat-coderd-tasks-data-model-split4_split branch October 13, 2025 09:26
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants