feat(coderd): add task status tracking and RBAC #20212

mafredri · 2025-10-08T11:51:25Z

This is a continuation of #19773.

Modify task_workspace_apps to link to workspace build number, allowing us to utilize sorting for the latest entry as well as retaining history
Dropped task_workspace_apps workspace_build_id since workspace_build_number makes it redundant (except for tracking foreign keys, if we want it can be added back)
Add tasks as a new RBAC object
Wire in tasks <-> task_workspace_apps linking in wsbuild and provisionerdserver
- wsbuild creates an early link to properly track build/job status of task ASAP
- provisionerdserver updates agent and app IDs upon completion
Noticed task name uniqueness constraint was missing and added it (can be split to separate PR)

Notes:

We probably need a query to update WorkspaceID for a task after-the-fact, but that can come later

mafredri · 2025-10-08T12:03:01Z

coderd/provisionerdserver/provisionerdserver.go

+				// the agent to a task. For now we overwrite the
+				// protoAgent.Id because that matches old behavior.
+				agentID := uuid.New()
+				protoAgent.Id = agentID.String()


Review: This is potentially the most controversial change. I've retain previous behavior in InsertWorkspaceResource if this value isn't set (e.g. template import).

This basically moves the behavior one level up so that we can access the ID here.

I definitely want to defer review of this section to someone with more provisioner knowledge than myself.

DanielleMaywood

I think this touches on some areas (namely wsbuilder and provisionerdserver) that I don't feel knowledgeable enough to give this the green light, but it looks good for the most part 👍

DanielleMaywood · 2025-10-08T12:37:45Z

coderd/database/querier_test.go

+
+		if agentState != "" {
+			agent := dbgen.WorkspaceAgent(t, db, database.WorkspaceAgent{
+				ResourceID: resource.ID,
+			})
+			workspaceAgentID := agent.ID
+
+			_, err := db.UpsertTaskWorkspaceApp(ctx, database.UpsertTaskWorkspaceAppParams{
+				TaskID:               task.ID,
+				WorkspaceBuildNumber: workspaceBuildNumber,
+				WorkspaceAgentID:     uuid.NullUUID{UUID: workspaceAgentID, Valid: true},
+			})
+			require.NoError(t, err)
+
+			err = db.UpdateWorkspaceAgentLifecycleStateByID(ctx, database.UpdateWorkspaceAgentLifecycleStateByIDParams{
+				ID:             agent.ID,
+				LifecycleState: agentState,
+			})
+			require.NoError(t, err)
+
+			for i, health := range appHealths {
+				app := dbgen.WorkspaceApp(t, db, database.WorkspaceApp{
+					AgentID:     workspaceAgentID,
+					Slug:        fmt.Sprintf("test-app-%d", i),
+					DisplayName: fmt.Sprintf("Test App %d", i+1),
+					Health:      health,
+				})
+				if i == 0 {
+					// Assume the first app is the tasks app.
+					_, err := db.UpsertTaskWorkspaceApp(ctx, database.UpsertTaskWorkspaceAppParams{
+						TaskID:               task.ID,
+						WorkspaceBuildNumber: workspaceBuildNumber,
+						WorkspaceAgentID:     uuid.NullUUID{UUID: workspaceAgentID, Valid: true},
+						WorkspaceAppID:       uuid.NullUUID{UUID: app.ID, Valid: true},
+					})
+					require.NoError(t, err)
+				}
+			}
+		}
+
+		return task


Invert the condition to reduce nesting

Suggested change

if agentState != "" {

agent := dbgen.WorkspaceAgent(t, db, database.WorkspaceAgent{

ResourceID: resource.ID,

})

workspaceAgentID := agent.ID

_, err := db.UpsertTaskWorkspaceApp(ctx, database.UpsertTaskWorkspaceAppParams{

TaskID: task.ID,

WorkspaceBuildNumber: workspaceBuildNumber,

WorkspaceAgentID: uuid.NullUUID{UUID: workspaceAgentID, Valid: true},

})

require.NoError(t, err)

err = db.UpdateWorkspaceAgentLifecycleStateByID(ctx, database.UpdateWorkspaceAgentLifecycleStateByIDParams{

ID: agent.ID,

LifecycleState: agentState,

})

require.NoError(t, err)

for i, health := range appHealths {

app := dbgen.WorkspaceApp(t, db, database.WorkspaceApp{

AgentID: workspaceAgentID,

Slug: fmt.Sprintf("test-app-%d", i),

DisplayName: fmt.Sprintf("Test App %d", i+1),

Health: health,

})

if i == 0 {

// Assume the first app is the tasks app.

_, err := db.UpsertTaskWorkspaceApp(ctx, database.UpsertTaskWorkspaceAppParams{

TaskID: task.ID,

WorkspaceBuildNumber: workspaceBuildNumber,

WorkspaceAgentID: uuid.NullUUID{UUID: workspaceAgentID, Valid: true},

WorkspaceAppID: uuid.NullUUID{UUID: app.ID, Valid: true},

})

require.NoError(t, err)

}

}

}

return task

if agentState == "" {

return task

}

agent := dbgen.WorkspaceAgent(t, db, database.WorkspaceAgent{

ResourceID: resource.ID,

})

workspaceAgentID := agent.ID

_, err := db.UpsertTaskWorkspaceApp(ctx, database.UpsertTaskWorkspaceAppParams{

TaskID: task.ID,

WorkspaceBuildNumber: workspaceBuildNumber,

WorkspaceAgentID: uuid.NullUUID{UUID: workspaceAgentID, Valid: true},

})

require.NoError(t, err)

err = db.UpdateWorkspaceAgentLifecycleStateByID(ctx, database.UpdateWorkspaceAgentLifecycleStateByIDParams{

ID: agent.ID,

LifecycleState: agentState,

})

require.NoError(t, err)

for i, health := range appHealths {

app := dbgen.WorkspaceApp(t, db, database.WorkspaceApp{

AgentID: workspaceAgentID,

Slug: fmt.Sprintf("test-app-%d", i),

DisplayName: fmt.Sprintf("Test App %d", i+1),

Health: health,

})

if i == 0 {

// Assume the first app is the tasks app.

_, err := db.UpsertTaskWorkspaceApp(ctx, database.UpsertTaskWorkspaceAppParams{

TaskID: task.ID,

WorkspaceBuildNumber: workspaceBuildNumber,

WorkspaceAgentID: uuid.NullUUID{UUID: workspaceAgentID, Valid: true},

WorkspaceAppID: uuid.NullUUID{UUID: app.ID, Valid: true},

})

require.NoError(t, err)

}

}

return task

DanielleMaywood · 2025-10-08T12:39:37Z

coderd/database/querier_test.go

+			buildStatus:     database.ProvisionerJobStatusRunning,
+			buildTransition: database.WorkspaceTransitionStart,
+			agentState:      database.WorkspaceAgentLifecycleStateReady,
+			appHealths:      []database.WorkspaceAppHealth{database.WorkspaceAppHealthHealthy, database.WorkspaceAppHealthHealthy},


It looks like this is the only test with two app healths, did we want any other tests that validate the behavior when an app that isn't the task app is unhealthy?

DanielleMaywood · 2025-10-08T12:40:46Z

coderd/provisionerdserver/provisionerdserver.go

+				// the agent to a task. For now we overwrite the
+				// protoAgent.Id because that matches old behavior.
+				agentID := uuid.New()
+				protoAgent.Id = agentID.String()


I definitely want to defer review of this section to someone with more provisioner knowledge than myself.

johnstcn · 2025-10-08T13:47:09Z

coderd/database/migrations/000378_create_tasks_with_status_view.up.sql

+UPDATE task_workspace_apps
+SET workspace_build_number = workspace_builds.build_number
+FROM workspace_builds
+WHERE workspace_builds.id = task_workspace_apps.workspace_build_id;


Nice! Can we also get workspace_agent_id and workspace_app_id or is that too much faff?

johnstcn · 2025-10-08T21:23:41Z

coderd/provisionerdserver/provisionerdserver.go


-		agentID := uuid.New()
+		var agentID uuid.UUID
+		if id, ok := predeterminedAgentID(prAgent.GetId()); ok {


So if I'm understanding correctly, this is to keep backward compatibility with older provisionerd versions that do not set the keep: prefix on the agent ID?

This change adds workspace build/agent/app linking to tasks and wires it into `wsbuilder` and `provisionerdserver`. Closes coder/internal#948 Closes #20212 Closes #19773

This change adds RBAC for tasks. Updates coder/internal#948 Supersedes #20212

This change adds workspace build/agent/app linking to tasks and wires it into `wsbuilder` and `provisionerdserver`. Closes coder/internal#948 Closes #20212 Closes #19773

This change adds RBAC for tasks. Updates coder/internal#948 Supersedes #20212

This change updates the `task_workspace_apps` table structure for improved linking to workspace builds and adds queries to manage tasks and a view to expose task status. Updates coder/internal#948 Supersedes #20212 Supersedes #19773

This change adds workspace build/agent/app linking to tasks and wires it into `wsbuilder` and `provisionerdserver`. Closes coder/internal#948 Closes #20212 Closes #19773

This change updates the `task_workspace_apps` table structure for improved linking to workspace builds and adds queries to manage tasks and a view to expose task status. Updates coder/internal#948 Supersedes #20212 Supersedes #19773

This change ensures task names are unique per user the same way we do for workspaces. This ensures we don't create tasks that are impossible to start due to another task being named the same creating a workspace name conflict. Updates coder/internal#948 Supersedes #20212

This change adds workspace build/agent/app linking to tasks and wires it into `wsbuilder` and `provisionerdserver`. Closes coder/internal#948 Closes #20212 Closes #19773

chore(coderd/database): support status for a task

956b1d1

github-actions bot assigned mafredri Oct 8, 2025

mafredri requested review from DanielleMaywood and johnstcn October 8, 2025 11:54

mafredri force-pushed the mafredri/feat-coderd-tasks-data-model branch from 6fdbe46 to 5fa8a93 Compare October 8, 2025 12:00

mafredri commented Oct 8, 2025

View reviewed changes

mafredri force-pushed the mafredri/feat-coderd-tasks-data-model branch from 5fa8a93 to b1e8378 Compare October 8, 2025 12:24

DanielleMaywood reviewed Oct 8, 2025

View reviewed changes

mafredri force-pushed the mafredri/feat-coderd-tasks-data-model branch from b1e8378 to 9f9d402 Compare October 8, 2025 13:34

BrunoQuaresma mentioned this pull request Oct 8, 2025

tasks: ui: update existing usages to new API coder/internal#904

Open

mafredri force-pushed the mafredri/feat-coderd-tasks-data-model branch 2 times, most recently from 36ff30a to fde6689 Compare October 8, 2025 14:15

mafredri added 2 commits October 8, 2025 14:57

feat(coderd): implement task to build/agent/app linking

3f416e4

fix: only use predetermined agent ID sometimes

12dc05e

mafredri force-pushed the mafredri/feat-coderd-tasks-data-model branch from fde6689 to 12dc05e Compare October 8, 2025 14:58

johnstcn reviewed Oct 8, 2025

View reviewed changes

mafredri added a commit that referenced this pull request Oct 9, 2025

feat(coderd): implement task to app linking

5adbc9d

This change adds workspace build/agent/app linking to tasks and wires it into `wsbuilder` and `provisionerdserver`. Closes coder/internal#948 Closes #20212 Closes #19773

This was referenced Oct 9, 2025

feat(coderd): add tasks rbac object #20234

Merged

feat(coderd/database): add task status and status view #20235

Merged

fix(coderd/database): ensure task name uniqueness #20236

Merged

feat(coderd): implement task to app linking #20237

Merged

mafredri added a commit that referenced this pull request Oct 9, 2025

feat(coderd): implement task to app linking

30464da

This change adds workspace build/agent/app linking to tasks and wires it into `wsbuilder` and `provisionerdserver`. Closes coder/internal#948 Closes #20212 Closes #19773

mafredri added a commit that referenced this pull request Oct 9, 2025

feat(coderd): implement task to app linking

d3fd9eb

This change adds workspace build/agent/app linking to tasks and wires it into `wsbuilder` and `provisionerdserver`. Closes coder/internal#948 Closes #20212 Closes #19773

mafredri added a commit that referenced this pull request Oct 9, 2025

feat(coderd): implement task to app linking

acd5dcf

This change adds workspace build/agent/app linking to tasks and wires it into `wsbuilder` and `provisionerdserver`. Closes coder/internal#948 Closes #20212 Closes #19773

mafredri added a commit that referenced this pull request Oct 9, 2025

feat(coderd): implement task to app linking

336477c

This change adds workspace build/agent/app linking to tasks and wires it into `wsbuilder` and `provisionerdserver`. Closes coder/internal#948 Closes #20212 Closes #19773

mafredri added a commit that referenced this pull request Oct 9, 2025

feat(coderd): add tasks rbac object

fffde2e

This change adds RBAC for tasks. Updates coder/internal#948 Supersedes #20212

mafredri added a commit that referenced this pull request Oct 9, 2025

feat(coderd): implement task to app linking

f7e0c43

This change adds workspace build/agent/app linking to tasks and wires it into `wsbuilder` and `provisionerdserver`. Closes coder/internal#948 Closes #20212 Closes #19773

mafredri added a commit that referenced this pull request Oct 13, 2025

feat(coderd): implement task to app linking

0bfe1ed

This change adds workspace build/agent/app linking to tasks and wires it into `wsbuilder` and `provisionerdserver`. Closes coder/internal#948 Closes #20212 Closes #19773

mafredri added a commit that referenced this pull request Oct 13, 2025

feat(coderd): add tasks rbac object (#20234)

299a54a

This change adds RBAC for tasks. Updates coder/internal#948 Supersedes #20212

mafredri added a commit that referenced this pull request Oct 13, 2025

feat(coderd): implement task to app linking

373b835

This change adds workspace build/agent/app linking to tasks and wires it into `wsbuilder` and `provisionerdserver`. Closes coder/internal#948 Closes #20212 Closes #19773

mafredri added a commit that referenced this pull request Oct 13, 2025

feat(coderd): implement task to app linking

c0e5cac

This change adds workspace build/agent/app linking to tasks and wires it into `wsbuilder` and `provisionerdserver`. Closes coder/internal#948 Closes #20212 Closes #19773

mafredri closed this in #20237 Oct 13, 2025

github-actions bot locked and limited conversation to collaborators Oct 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(coderd): add task status tracking and RBAC #20212

feat(coderd): add task status tracking and RBAC #20212

Uh oh!

mafredri commented Oct 8, 2025

Uh oh!

mafredri Oct 8, 2025

Uh oh!

DanielleMaywood Oct 8, 2025

Uh oh!

DanielleMaywood left a comment

Uh oh!

DanielleMaywood Oct 8, 2025

Uh oh!

DanielleMaywood Oct 8, 2025

Uh oh!

DanielleMaywood Oct 8, 2025

Uh oh!

johnstcn Oct 8, 2025

Uh oh!

johnstcn Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(coderd): add task status tracking and RBAC #20212

feat(coderd): add task status tracking and RBAC #20212

Uh oh!

Conversation

mafredri commented Oct 8, 2025

Uh oh!

mafredri Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

DanielleMaywood Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

DanielleMaywood left a comment

Choose a reason for hiding this comment

Uh oh!

DanielleMaywood Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

DanielleMaywood Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

DanielleMaywood Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

johnstcn Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

johnstcn Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants