Skip to content

feat: make ServerTailnet set peers lost when it reconnects to the coordinator #11682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spikecurtis merged 1 commit into from
Jan 23, 2024
Merged

feat: make ServerTailnet set peers lost when it reconnects to the coordinator #11682

spikecurtis merged 1 commit into from
Jan 23, 2024

Conversation

@spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jan 18, 2024 •
edited
Loading

Adds support to ServerTailnet to set all peers lost before attempting to reconnect to the coordinator. In practice, this only really affects wsproxy since coderd has a local connection to the coordinator that only goes down if we're shutting down or change licenses.

This was referenced Jan 18, 2024
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 18, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@spikecurtis spikecurtis requested a review from coadler January 18, 2024 10:06
@spikecurtis spikecurtis marked this pull request as ready for review January 18, 2024 10:06
@spikecurtis spikecurtis force-pushed the spike/10533-set-lost-disconnect branch from caedbc8 to 951f803 Compare January 19, 2024 06:59
@spikecurtis spikecurtis force-pushed the spike/10533-servertailnet-set-lost branch from 26cef57 to fc29043 Compare January 19, 2024 06:59
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Jan 19, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis force-pushed the spike/10533-set-lost-disconnect branch from 951f803 to 771cdf1 Compare January 19, 2024 08:20
@spikecurtis spikecurtis force-pushed the spike/10533-servertailnet-set-lost branch from fc29043 to c7f73d4 Compare January 19, 2024 08:20
@spikecurtis spikecurtis mentioned this pull request Jan 19, 2024
Merged
@spikecurtis spikecurtis force-pushed the spike/10533-set-lost-disconnect branch from 771cdf1 to 2d92458 Compare January 19, 2024 12:36
@spikecurtis spikecurtis force-pushed the spike/10533-servertailnet-set-lost branch from c7f73d4 to 135bd48 Compare January 19, 2024 12:36
@spikecurtis spikecurtis mentioned this pull request Jan 19, 2024
Merged
@spikecurtis spikecurtis force-pushed the spike/10533-set-lost-disconnect branch from 2d92458 to 9c1f310 Compare January 22, 2024 06:58
@spikecurtis spikecurtis force-pushed the spike/10533-servertailnet-set-lost branch from 135bd48 to ecef2a9 Compare January 22, 2024 06:58
@spikecurtis spikecurtis force-pushed the spike/10533-set-lost-disconnect branch from 9c1f310 to 53b97df Compare January 22, 2024 08:05
@spikecurtis spikecurtis force-pushed the spike/10533-servertailnet-set-lost branch from ecef2a9 to 0b0b1a4 Compare January 22, 2024 08:05
@spikecurtis spikecurtis force-pushed the spike/10533-set-lost-disconnect branch from 53b97df to 9cf8f03 Compare January 22, 2024 11:18
@spikecurtis spikecurtis force-pushed the spike/10533-servertailnet-set-lost branch from 0b0b1a4 to 7a301f1 Compare January 22, 2024 11:18
@spikecurtis spikecurtis mentioned this pull request Jan 22, 2024
Merged
Base automatically changed from spike/10533-set-lost-disconnect to main January 22, 2024 11:26
@spikecurtis spikecurtis force-pushed the spike/10533-servertailnet-set-lost branch 4 times, most recently from 66da7c6 to 62e95de Compare January 23, 2024 05:52
@spikecurtis spikecurtis force-pushed the spike/10533-servertailnet-set-lost branch from 62e95de to 5695841 Compare January 23, 2024 09:09
@spikecurtis spikecurtis merged commit eb12fd7 into main Jan 23, 2024
@spikecurtis spikecurtis deleted the spike/10533-servertailnet-set-lost branch January 23, 2024 09:17
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Jan 23, 2024

Merge activity

@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@coadler coadler coadler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@spikecurtis spikecurtis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spikecurtis @coadler