Skip to content

chore: add setCallback to nodeUpdater #11635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spikecurtis merged 1 commit into from
Jan 18, 2024
Merged

chore: add setCallback to nodeUpdater #11635

spikecurtis merged 1 commit into from
Jan 18, 2024

Conversation

@spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jan 16, 2024 •
edited
Loading

we need to be able to (re-)set the node callback when we lose and regain connection to a coordinator over the network.

This was referenced Jan 16, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 16, 2024
Merged
Merged
Merged
Merged
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Jan 16, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

This was referenced Jan 16, 2024
Merged
Merged
Merged
@spikecurtis spikecurtis requested a review from coadler January 16, 2024 12:29
@spikecurtis spikecurtis marked this pull request as ready for review January 16, 2024 12:29
@spikecurtis spikecurtis force-pushed the spike/10533-addresses-constructor branch from 50b2855 to cf32bef Compare January 17, 2024 04:56
@spikecurtis spikecurtis force-pushed the spike/10533-setCallback branch from 54af820 to b050932 Compare January 17, 2024 04:56
@spikecurtis spikecurtis force-pushed the spike/10533-addresses-constructor branch from cf32bef to df12694 Compare January 17, 2024 05:41
@spikecurtis spikecurtis force-pushed the spike/10533-setCallback branch from b050932 to 03180f7 Compare January 17, 2024 05:41
@spikecurtis spikecurtis force-pushed the spike/10533-addresses-constructor branch from df12694 to 5ed9e70 Compare January 17, 2024 10:03
@spikecurtis spikecurtis force-pushed the spike/10533-setCallback branch from 03180f7 to fb52b92 Compare January 17, 2024 10:03
@spikecurtis spikecurtis force-pushed the spike/10533-addresses-constructor branch from 5ed9e70 to 3d1daef Compare January 17, 2024 11:49
@spikecurtis spikecurtis force-pushed the spike/10533-setCallback branch from fb52b92 to 1d34dfb Compare January 17, 2024 11:49
@spikecurtis spikecurtis mentioned this pull request Jan 17, 2024
Merged
@spikecurtis spikecurtis force-pushed the spike/10533-addresses-constructor branch from 3d1daef to c6faac9 Compare January 18, 2024 05:34
Base automatically changed from spike/10533-addresses-constructor to main January 18, 2024 05:43
@spikecurtis spikecurtis force-pushed the spike/10533-setCallback branch from 1d34dfb to 32396d0 Compare January 18, 2024 05:43
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Jan 18, 2024 •
edited
Loading

Merge activity

  • Jan 18, 12:44 AM: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Jan 18, 12:51 AM: @spikecurtis merged this pull request with Graphite.

@spikecurtis spikecurtis merged commit 5b4de66 into main Jan 18, 2024
@spikecurtis spikecurtis deleted the spike/10533-setCallback branch January 18, 2024 05:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@coadler coadler coadler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@spikecurtis spikecurtis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spikecurtis @coadler