This repository was archived by the owner on Jun 24, 2024. It is now read-only.
deps: use custom build of aria-query@5.0.0#95
Merged
Conversation
Version 5.0.0 of the aria-query package currently includes files with
spaces in their names [1], but those files aren't used at build- or
run-time. Since this package is always present in a hydrated
cockroach.git clone, a custom version of aria-query [2] can be used with a
yarn "resolutions" entry, i.e.:
{
"name": "example-package",
"dependencies": {
"...": "..."
},
"resolutions": {
"aria-query": "file:../rel/path/to/yarn-vendor/aria-query-5.0.0-no-spaced-files.tgz"
}
}
Replace the corrupt aria-query build with a custom build that doesn't
include extra files.
[1] A11yance/aria-query#367
[2] https://github.com/cockroachdb/aria-query/releases/tag/v5.0.0-no-extra-files
sjbarag
added a commit
to sjbarag/cockroach
that referenced
this pull request
Jun 15, 2022
Version 5.0.0 of the aria-query package currently includes files with spaces in their names [1], but those files aren't used at build- or run-time. Unfortunately, Bazel doesn't support referencing *any* file with a space in its name -- including transitively. The yarn-vendored submodule recently received [2]a copy of aria-query without those extra files [3], but using it requires a custom yarn resolution for all packages that transitively depend on aria-query. Replace the corrupt aria-query build with a custom build that doesn't include extra files. [1] A11yance/aria-query#367 [2] cockroachdb/yarn-vendored#95 [3] https://github.com/cockroachdb/aria-query/releases/tag/v5.0.0-no-extra-files Release note: None
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Jun 15, 2022
82961: ui: use custom build of aria-query@5.0.0 (#95) r=rickystewart,maryliag a=sjbarag Version 5.0.0 of the aria-query package currently includes files with spaces in their names [1], but those files aren't used at build- or run-time. Unfortunately, Bazel doesn't support referencing *any* file with a space in its name -- including transitively. The yarn-vendored submodule recently received [2]a copy of aria-query without those extra files [3], but using it requires a custom yarn resolution for all packages that transitively depend on aria-query. Replace the corrupt aria-query build with a custom build that doesn't include extra files. [1] A11yance/aria-query#367 [2] cockroachdb/yarn-vendored#95 [3] https://github.com/cockroachdb/aria-query/releases/tag/v5.0.0-no-extra-files Release note: None Co-authored-by: Sean Barag <barag@cockroachlabs.com>
sjbarag
added a commit
that referenced
this pull request
Dec 21, 2022
aria-query@5.0.0 included extra files with spaces in their filename, which caused errors when Bazel interacted with them. To work around that, we produced a copy of 5.0.0 that removed those files [1]. The upstream maintainers published version 5.0.1 which includes no other changes (but no spurious files) [2], so add that to the set of available dependencies. [1] 1dea01c (deps: use custom build of aria-query@5.0.0 (#95), 2022-06-15) [2] A11yance/aria-query#367
sjbarag
added a commit
that referenced
this pull request
Dec 21, 2022
aria-query@5.0.0 included extra files with spaces in their filename, which caused errors when Bazel interacted with them. To work around that, we produced a copy of 5.0.0 that removed those files [1]. The upstream maintainers published version 5.0.1 which includes no other changes (but no spurious files) [2], so add that to the set of available dependencies. [1] 1dea01c (deps: use custom build of aria-query@5.0.0 (#95), 2022-06-15) [2] A11yance/aria-query#367
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 5.0.0 of the aria-query package currently includes files with
spaces in their names [1], but those files aren't used at build- or
run-time. Since this package is always present in a hydrated
cockroach.git clone, a custom version of aria-query [2] can be used with a
yarn "resolutions" entry, i.e.:
Replace the corrupt aria-query build with a custom build that doesn't
include extra files.
[1] A11yance/aria-query#367
[2] https://github.com/cockroachdb/aria-query/releases/tag/v5.0.0-no-extra-files