ui: use custom build of aria-query@5.0.0 (#95)#82961
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 15, 2022
Merged
ui: use custom build of aria-query@5.0.0 (#95)#82961craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Version 5.0.0 of the aria-query package currently includes files with spaces in their names [1], but those files aren't used at build- or run-time. Unfortunately, Bazel doesn't support referencing *any* file with a space in its name -- including transitively. The yarn-vendored submodule recently received [2]a copy of aria-query without those extra files [3], but using it requires a custom yarn resolution for all packages that transitively depend on aria-query. Replace the corrupt aria-query build with a custom build that doesn't include extra files. [1] A11yance/aria-query#367 [2] cockroachdb/yarn-vendored#95 [3] https://github.com/cockroachdb/aria-query/releases/tag/v5.0.0-no-extra-files Release note: None
Member
|
This change is |
maryliag
approved these changes
Jun 15, 2022
Contributor
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @irfansharif, @knz, and @rickystewart)
rickystewart
approved these changes
Jun 15, 2022
Contributor
Author
|
bors r=rickystewart,maryliag |
knz
approved these changes
Jun 15, 2022
Contributor
knz
left a comment
There was a problem hiding this comment.
maybe you can remove the find command from the script then?
Contributor
Author
Lots of people are blocked on this PR so I'll handle that in a separate PR. It's pretty harmless to stick around :) |
Contributor
Author
|
bors p=1 |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 5.0.0 of the aria-query package currently includes files with
spaces in their names [1], but those files aren't used at build- or
run-time. Unfortunately, Bazel doesn't support referencing any file
with a space in its name -- including transitively. The yarn-vendored
submodule recently received [2]a copy of aria-query without those extra
files [3], but using it requires a custom yarn resolution for all
packages that transitively depend on aria-query. Replace the corrupt
aria-query build with a custom build that doesn't include extra files.
[1] A11yance/aria-query#367
[2] cockroachdb/yarn-vendored#95
[3] https://github.com/cockroachdb/aria-query/releases/tag/v5.0.0-no-extra-files
Release note: None