also write test stderr to json (xml) output file#7
Merged
rickystewart merged 1 commit intorelease-0.33from Sep 7, 2022
Merged
Conversation
Without this, people are forced to look in the test.log file for output to stderr, rather than test.xml.
healthy-pod
approved these changes
Aug 31, 2022
| func Wrap(pkg string) error { | ||
| var jsonBuffer bytes.Buffer | ||
| jsonConverter := NewConverter(&jsonBuffer, pkg, Timestamp) | ||
| pipeRead, pipeWrite := io.Pipe() |
There was a problem hiding this comment.
Why is a pipe needed/chosen here over the following?
cmd.Stderr = io.MultiWriter(os.Stderr, jsonConverter)
cmd.Stdout = io.MultiWriter(os.Stdout, jsonConverter)
Author
There was a problem hiding this comment.
This is what I tried first, but it's racy since we have two streams writing to the same underlying bytes.Buffer. The io.Pipe is thread-safe.
rickystewart
added a commit
to rickystewart/cockroach
that referenced
this pull request
Sep 7, 2022
Pull in cockroachdb/rules_go#7. Closes cockroachdb#69534. Closes cockroachdb#85650. Closes cockroachdb#87186. Release justification: Non-production code changes Release note: None
blathers-crl bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Sep 8, 2022
Pull in cockroachdb/rules_go#7. Closes #69534. Closes #85650. Closes #87186. Release justification: Non-production code changes Release note: None
rickystewart
added a commit
to cockroachdb/cockroach
that referenced
this pull request
Sep 15, 2022
Pull in cockroachdb/rules_go#7. Closes #69534. Closes #85650. Closes #87186. Release justification: Non-production code changes Release note: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, people are forced to look in the test.log file for output
to stderr, rather than test.xml.