Ensure the test callback sees the sub-test instance#7
Merged
knz merged 1 commit intocockroachdb:masterfrom Nov 25, 2019
Merged
Conversation
8c8a432 to
061091c
Compare
tbg
approved these changes
Nov 25, 2019
Member
tbg
left a comment
There was a problem hiding this comment.
I would greatly prefer the breaking API change here (i.e. passing t through) as the current solution leaves the footgun in place (nobody will remember to use d.T in their handler).
Contributor
Author
|
ok I'll make an attempt at shaving this yak before I fix cockroachdb/cockroach#42250 |
Contributor
Author
|
I found this API usage error while attempting to run t.Fatal or t.Skip inside a test directive: it's not possible to change the status of an outer test instance while `datadriven.RunTest` has instantiated a sub-test. Symptom: ``` test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test ``` This patch fixes it by giving the sub-test instance to the callback. All usages must be updated.
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Nov 26, 2019
42736: *: bump the `datadriven` dependency and update the calls r=knz a=knz For use with cockroachdb/datadriven#7. The `datadriven.RunTest` function uses sub-tests for each directive in the input file. Since it's not valid to use `t.Fatal`, `t.Skip` etc on a parent test while there is a sub-test `testing.T` active, the `RunTest` interface has been updated so that the callback function gets the sub-test as argument. This patch bumps the dependency and updates the calls to `RunTest` accordingly. Release note: None Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this API usage error while attempting to run t.Fatal or t.Skip
inside a test directive: it's not possible to change the status of an
outer test instance while
datadriven.RunTesthas instantiated asub-test.
Symptom:
This patch fixes it by giving the sub-test instance to the
callback. All usages must be updated.
Needed for cockroachdb/cockroach#42250.
This change is