*: bump the datadriven dependency and update the calls#42736
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 26, 2019
Merged
*: bump the datadriven dependency and update the calls#42736craig[bot] merged 1 commit intocockroachdb:masterfrom
datadriven dependency and update the calls#42736craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
7b1d7d5 to
bee94fc
Compare
tbg
approved these changes
Nov 25, 2019
RaduBerinde
approved these changes
Nov 25, 2019
Contributor
Author
|
I'll wait for some discussion on cockroachdb/datadriven#8 before merging this. If we end up removing the sub-tests, then the interface change is not required. |
Contributor
Author
|
I have thought about this more. Regardless of the discussion on cockroachdb/datadriven#8 it's desirable to pass the So merging nonetheless. bors r+ |
Contributor
Merge conflict |
bee94fc to
5739fe5
Compare
The `datadriven.RunTest` function uses sub-tests for each directive in the input file. Since it's not valid to use `t.Fatal`, `t.Skip` etc on a parent test while there is a sub-test `testing.T` active, the `RunTest` interface has been updated so that the callback function gets the sub-test as argument. This patch bumps the dependency and updates the calls to `RunTest` accordingly. Release note: None
5739fe5 to
96910cd
Compare
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 26, 2019
42736: *: bump the `datadriven` dependency and update the calls r=knz a=knz For use with cockroachdb/datadriven#7. The `datadriven.RunTest` function uses sub-tests for each directive in the input file. Since it's not valid to use `t.Fatal`, `t.Skip` etc on a parent test while there is a sub-test `testing.T` active, the `RunTest` interface has been updated so that the callback function gets the sub-test as argument. This patch bumps the dependency and updates the calls to `RunTest` accordingly. Release note: None Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For use with cockroachdb/datadriven#7.
The
datadriven.RunTestfunction uses sub-tests for each directive inthe input file. Since it's not valid to use
t.Fatal,t.Skipetc ona parent test while there is a sub-test
testing.Tactive, theRunTestinterface has been updated so that the callback functiongets the sub-test as argument.
This patch bumps the dependency and updates the calls to
RunTestaccordingly.
Release note: None