Skip to content

grunning: exclude s390x#95291

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
linux-on-ibm-z:s390x-grunning
Jan 17, 2023
Merged

grunning: exclude s390x#95291
craig[bot] merged 1 commit intocockroachdb:masterfrom
linux-on-ibm-z:s390x-grunning

Conversation

@vivkong
Copy link
Copy Markdown
Contributor

@vivkong vivkong commented Jan 16, 2023 •
edited
Loading

As the patched Go runtime is not available, disable grunning library on s390x.

When s390x artifacts are made available (#92393), we can re-enable the library.

Thanks.

Release note: None
Epic: none

@vivkong vivkong requested a review from a team as a code owner January 16, 2023 14:43
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Jan 16, 2023

This change is Reviewable

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Jan 16, 2023

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added the O-community Originated from the community label Jan 16, 2023
@irfansharif irfansharif requested a review from a team January 16, 2023 15:49
@vivkong
Copy link
Copy Markdown
Contributor Author

vivkong commented Jan 16, 2023

It looks like TestProportionalGoroutines has failed in the Extended CI and has passed in the Essential CI. Can the Extended CI be trigger again? Thanks.

@healthy-pod
Copy link
Copy Markdown
Contributor

healthy-pod commented Jan 16, 2023

Hey @vivkong, the failure is a legit data race that is not a result of your change. Please rebase when the fix in #95327 is merged.

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Jan 17, 2023

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Jan 17, 2023

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@vivkong
Copy link
Copy Markdown
Contributor Author

vivkong commented Jan 17, 2023

I've rebased as #95327 has been merged. Thanks @healthy-pod!

@irfansharif
Copy link
Copy Markdown
Contributor

irfansharif commented Jan 17, 2023

bors r=rickystewart

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 17, 2023

Build succeeded:

@craig craig bot merged commit 2ee814f into cockroachdb:master Jan 17, 2023
@Nayana-ibm Nayana-ibm mentioned this pull request Jul 17, 2023
Closed
yasiribmcon added a commit to linux-on-ibm-z/cockroach that referenced this pull request Jul 23, 2024
@yasiribmcon
Include grunning for s390x.
7ea2014 
PR cockroachdb#95291 excluded grunning from s390x as patched Go runtime was not available.
Since we can refer go patch at https://github.com/cockroachdb/cockroach/blob/master/build/teamcity/internal/release/build-and-publish-patched-go/diff.patch, we can manually patch go runtime for s390x so that grunning works for s390x.
Hence enabling back this library for s390x.
@yasiribmcon yasiribmcon mentioned this pull request Jul 26, 2024
Merged
craig bot pushed a commit that referenced this pull request Jul 30, 2024
@yasiribmcon
Merge #127719
e8e4cce 
127719: Include grunning for s390x. r=rickystewart a=yasiribmcon

PR #95291 excluded grunning from s390x as patched Go runtime is not available. 

Since we can refer go patch from [here](https://github.com/cockroachdb/cockroach/blob/master/build/teamcity/internal/release/build-and-publish-patched-go/diff.patch), we can manually patch go runtime for s390x so that grunning works for s390x.

Hence enabling back this library for s390x.

Co-authored-by: yasiribmcon <107119183+yasiribmcon@users.noreply.github.com>
Co-authored-by: yasiribmcon <Yasir.Ashfaq1@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickystewart rickystewart rickystewart approved these changes

Assignees

No one assigned

Labels

O-community Originated from the community

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vivkong @cockroach-teamcity @healthy-pod @irfansharif @rickystewart