Include grunning for s390x.#127719
Conversation
PR cockroachdb#95291 excluded grunning from s390x as patched Go runtime was not available. Since we can refer go patch at https://github.com/cockroachdb/cockroach/blob/master/build/teamcity/internal/release/build-and-publish-patched-go/diff.patch, we can manually patch go runtime for s390x so that grunning works for s390x. Hence enabling back this library for s390x.
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Are you saying the existing patch works for s390x and all we need to do is remove s390x from the disabled list? @rickystewart, since I am unsure of the build subtleties of the patched runtime. |
|
Yes @sumeerbhola, go patch works fine for s390x machines, we only need to remove s390x from disabled list. On a side note, we had also raised an issue previously to add s390x artifacts here fyi. |
rickystewart
left a comment
There was a problem hiding this comment.
Please do bazel run :gazelle to clean up BUILD.bazel
Ran "bazel run :gazelle" command after which "pkg/util/grunning/BUILD.bazel" got updated.
|
Thank you for updating your pull request. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
@rickystewart Done! |
|
bors r+ |
PR #95291 excluded grunning from s390x as patched Go runtime is not available.
Since we can refer go patch from here, we can manually patch go runtime for s390x so that grunning works for s390x.
Hence enabling back this library for s390x.