kvserver: don't consider followers to have pending proposal quota#94558
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 3, 2023
Merged
Conversation
`Replica.hasPendingProposalQuotaRLocked()` considered a replica with `proposalQuota == nil` to have pending proposal quota, which in turn prevented quiescence. This condition is only possible on followers, which won't be able to quiesce anyway since we explicitly check for leadership. This can be misleading in vmodule logs, which claim "not quiescing: replication quota outstanding" on all followers. This patch instead considers followers to have no pending proposal quota, thus vmodule logs will emit the more accurate "not quiescing: not leader". This may lead to higher CPU usage on followers, because we now fall through to a `raftStatusRLocked` check which is more expensive. This should be optimized separately. Epic: none Release note: None
Member
|
This change is |
Contributor
Author
|
Much of the additional cost here is reduced by #94594. |
Contributor
Author
|
#94595 eliminates the performance penalty of this change. |
tbg
approved these changes
Jan 3, 2023
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replica.hasPendingProposalQuotaRLocked()considered a replica withproposalQuota == nilto have pending proposal quota, which in turn prevented quiescence. This condition is only possible on followers, which won't be able to quiesce anyway since we explicitly check for leadership. This can be misleading in vmodule logs, which claim "not quiescing: replication quota outstanding" on all followers.This patch instead considers followers to have no pending proposal quota, thus vmodule logs will emit the more accurate "not quiescing: not leader".
This may lead to higher CPU usage on followers, because we now fall through to a
raftStatusRLockedcheck which is more expensive. This should be optimized separately.Touches #94457.
Epic: none
Release note: None