kvserver: use cheaper raftSparseStatus during replica ticks#94594
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 3, 2023
Merged
kvserver: use cheaper raftSparseStatus during replica ticks#94594craig[bot] merged 1 commit intocockroachdb:masterfrom
raftSparseStatus during replica ticks#94594craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
In an idle cluster with many unquiesced replicas, 40% of the `Replica.tick` CPU time is spent on `raft.RawNode.Status()`, when considering quiescence and Raft leadership transfers. This status call incurs expensive deep copies of the `Config` and `Progress.Inflights` fields, but these fields are never used by the callers. This patch instead introduces a `raftSparseStatus` without these expensive and unnecessary fields, which reduces the CPU cost of ticks by about 20%. Epic: none Release note: None
Member
|
This change is |
tbg
approved these changes
Jan 3, 2023
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an idle cluster with many unquiesced replicas, 40% of the
Replica.tickCPU time is spent onraft.RawNode.Status(), when considering quiescence and Raft leadership transfers. This status call incurs expensive deep copies of theConfigandProgress.Inflightsfields, but these fields are never used by the callers.This patch instead introduces a
raftSparseStatuswithout these expensive and unnecessary fields, which reduces the CPU cost of ticks by about 20%.Touches #94592.
Touches #94609.
Epic: none
Release note: None