bench: add tenant benchmark#93530
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 14, 2022
Merged
Conversation
Member
|
This change is |
This patch adds another mode for the benchmarks in the pkg/bench - run against an in-memory tenant in a single-node cluster. Currently, the difference between that and single-node cockroach on BenchmarkSQL, for example, is major. Release note: None Epic: None
3c798c9 to
6b6002a
Compare
andreimatei
commented
Dec 14, 2022
Contributor
Author
andreimatei
left a comment
There was a problem hiding this comment.
bors r+
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ajstorm)
Contributor
|
Build succeeded: |
renatolabs
pushed a commit
to renatolabs/cockroach
that referenced
this pull request
Dec 14, 2022
Fixes argument passed to `crdb_internal.create_tenant` to remove underscore, which is rejected as an invalid name; and also use the `bench` database in `tenantDB`. Relates to cockroachdb#93530. Epic: none Release note: None
renatolabs
pushed a commit
to renatolabs/cockroach
that referenced
this pull request
Dec 14, 2022
Fixes argument passed to `crdb_internal.create_tenant` to remove underscore, which is rejected as an invalid name; and also use the `bench` database in `tenantDB`. Relates to cockroachdb#93530. Epic: none Release note: None
craig bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
93300: builtins: implement parse_ident function r=ZhouXing19 a=rafiss fixes #93159 The implementation was adapted from the Postgres one. Release note (sql change): Implemented the parse_ident builtin. The function splits a qualified identifier into an array of identifiers, removing any quoting of individual identifiers. By default, extra characters after the last identifier are considered an error; but if the second parameter is false, then such extra characters are ignored. 93607: TEAMS: rename sql-experience to sql-sessions r=rafiss a=rafiss Epic: None Release note: None 93616: bench: fix tenant benchmark r=yuzefovich,andreimatei a=renatolabs Fixes argument passed to `crdb_internal.create_tenant` to remove underscore, which is rejected as an invalid name; and also use the `bench` database in `tenantDB`. Relates to #93530. Epic: none Release note: None 93627: ci: fix error in nightly builder update check r=rickystewart a=healthy-pod Release note: None Epic: none Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Renato Costa <renato@cockroachlabs.com> Co-authored-by: healthy-pod <ahmad@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds another mode for the benchmarks in the pkg/bench - run against an in-memory tenant in a single-node cluster. Currently, the difference between that and single-node cockroach on BenchmarkSQL, for example, is major.
Release note: None
Epic: None