Skip to content

TEAMS: rename sql-experience to sql-sessions#93607

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:rename-sql-sessions
Dec 14, 2022
Merged

TEAMS: rename sql-experience to sql-sessions#93607
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:rename-sql-sessions

Conversation

@rafiss
Copy link
Copy Markdown
Collaborator

@rafiss rafiss commented Dec 14, 2022

Epic: None
Release note: None

@rafiss rafiss requested a review from jordanlewis December 14, 2022 15:19
@rafiss rafiss requested review from a team as code owners December 14, 2022 15:19
@rafiss rafiss requested review from a team, renatolabs and srosenberg and removed request for a team December 14, 2022 15:19
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@renatolabs
Copy link
Copy Markdown

The changes on conn_test.go seem unrelated.

@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Dec 14, 2022

whoops that was from debugging #93538

Release note: None
@rafiss rafiss force-pushed the rename-sql-sessions branch from 73746a7 to 1a34b58 Compare December 14, 2022 15:44
Copy link
Copy Markdown

@renatolabs renatolabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @srosenberg)

@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Dec 14, 2022

tftr!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 14, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 14, 2022

Build succeeded:

@craig craig bot merged commit dbea195 into cockroachdb:master Dec 14, 2022
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Dec 14, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 1a34b58 to blathers/backport-release-22.1-93607: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


error creating merge commit from 1a34b58 to blathers/backport-release-22.2-93607: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants