Skip to content

Commit 1a34b58

Browse files
rafissrafiss
committed
TEAMS: rename to sql-sessions
Release note: None
1 parent 3ef084c commit 1a34b58

6 files changed

Lines changed: 41 additions & 42 deletions

File tree

‎.github/CODEOWNERS‎

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -59,18 +59,18 @@
5959
/pkg/sql/show_create*.go @cockroachdb/sql-syntax-prs
6060
/pkg/sql/types/ @cockroachdb/sql-syntax-prs
6161

62-
/pkg/sql/crdb_internal.go @cockroachdb/sql-experience
63-
/pkg/sql/pg_catalog.go @cockroachdb/sql-experience
64-
/pkg/sql/pgwire/ @cockroachdb/sql-experience @cockroachdb/server-prs
65-
/pkg/sql/pgwire/auth.go @cockroachdb/sql-experience @cockroachdb/server-prs @cockroachdb/prodsec
66-
/pkg/sql/sem/builtins/ @cockroachdb/sql-experience
67-
/pkg/sql/vtable/ @cockroachdb/sql-experience
68-
/pkg/sql/importer/ @cockroachdb/sql-experience
69-
/pkg/ccl/importerccl/ @cockroachdb/sql-experience
62+
/pkg/sql/crdb_internal.go @cockroachdb/sql-sessions
63+
/pkg/sql/pg_catalog.go @cockroachdb/sql-sessions
64+
/pkg/sql/pgwire/ @cockroachdb/sql-sessions @cockroachdb/server-prs
65+
/pkg/sql/pgwire/auth.go @cockroachdb/sql-sessions @cockroachdb/server-prs @cockroachdb/prodsec
66+
/pkg/sql/sem/builtins/ @cockroachdb/sql-sessions
67+
/pkg/sql/vtable/ @cockroachdb/sql-sessions
68+
/pkg/sql/importer/ @cockroachdb/sql-sessions
69+
/pkg/ccl/importerccl/ @cockroachdb/sql-sessions
7070

71-
/pkg/sql/sessiondata/ @cockroachdb/sql-experience
72-
/pkg/sql/tests/rsg_test.go @cockroachdb/sql-experience
73-
/pkg/sql/ttl @cockroachdb/sql-experience
71+
/pkg/sql/sessiondata/ @cockroachdb/sql-sessions
72+
/pkg/sql/tests/rsg_test.go @cockroachdb/sql-sessions
73+
/pkg/sql/ttl @cockroachdb/sql-sessions
7474

7575
/pkg/ccl/schemachangerccl/ @cockroachdb/sql-schema
7676
/pkg/sql/catalog/ @cockroachdb/sql-schema
@@ -97,17 +97,17 @@
9797
/pkg/cli/userfile.go @cockroachdb/disaster-recovery
9898
/pkg/cli/auth.go @cockroachdb/unowned @cockroachdb/prodsec @cockroachdb/cli-prs
9999
/pkg/cli/cert*.go @cockroachdb/cli-prs @cockroachdb/prodsec
100-
/pkg/cli/demo*.go @cockroachdb/sql-experience @cockroachdb/server-prs @cockroachdb/cli-prs
101-
/pkg/cli/democluster @cockroachdb/sql-experience @cockroachdb/server-prs @cockroachdb/cli-prs
100+
/pkg/cli/demo*.go @cockroachdb/sql-sessions @cockroachdb/server-prs @cockroachdb/cli-prs
101+
/pkg/cli/democluster @cockroachdb/sql-sessions @cockroachdb/server-prs @cockroachdb/cli-prs
102102
/pkg/cli/debug*.go @cockroachdb/kv-prs @cockroachdb/cli-prs
103103
/pkg/cli/debug_job_trace*.go @cockroachdb/jobs-prs
104104
/pkg/cli/doctor*.go @cockroachdb/sql-schema @cockroachdb/cli-prs
105-
/pkg/cli/import_test.go @cockroachdb/sql-experience @cockroachdb/cli-prs
106-
/pkg/cli/sql*.go @cockroachdb/sql-experience @cockroachdb/cli-prs
107-
/pkg/cli/clisqlshell/ @cockroachdb/sql-experience @cockroachdb/cli-prs
108-
/pkg/cli/clisqlclient/ @cockroachdb/sql-experience @cockroachdb/cli-prs
109-
/pkg/cli/clisqlcfg/ @cockroachdb/sql-experience @cockroachdb/cli-prs
110-
/pkg/cli/clisqlexec/ @cockroachdb/sql-experience @cockroachdb/cli-prs
105+
/pkg/cli/import_test.go @cockroachdb/sql-sessions @cockroachdb/cli-prs
106+
/pkg/cli/sql*.go @cockroachdb/sql-sessions @cockroachdb/cli-prs
107+
/pkg/cli/clisqlshell/ @cockroachdb/sql-sessions @cockroachdb/cli-prs
108+
/pkg/cli/clisqlclient/ @cockroachdb/sql-sessions @cockroachdb/cli-prs
109+
/pkg/cli/clisqlcfg/ @cockroachdb/sql-sessions @cockroachdb/cli-prs
110+
/pkg/cli/clisqlexec/ @cockroachdb/sql-sessions @cockroachdb/cli-prs
111111
/pkg/cli/start*.go @cockroachdb/cli-prs @cockroachdb/server-prs
112112
/pkg/cli/mt_proxy.go @cockroachdb/sqlproxy-prs @cockroachdb/server-prs
113113
/pkg/cli/mt_start_sql.go @cockroachdb/sqlproxy-prs @cockroachdb/server-prs
@@ -139,7 +139,7 @@
139139
/pkg/server/node_http*.go @cockroachdb/obs-inf-prs @cockroachdb/server-prs
140140
/pkg/server/node_tenant*go @cockroachdb/obs-inf-prs @cockroachdb/multi-tenant @cockroachdb/server-prs
141141
/pkg/server/node_tombstone*.go @cockroachdb/kv-prs @cockroachdb/server-prs
142-
/pkg/server/pgurl/ @cockroachdb/sql-experience @cockroachdb/cli-prs
142+
/pkg/server/pgurl/ @cockroachdb/sql-sessions @cockroachdb/cli-prs
143143
/pkg/server/server_http*.go @cockroachdb/obs-inf-prs @cockroachdb/server-prs
144144
/pkg/server/server_import_ts*.go @cockroachdb/obs-inf-prs @cockroachdb/kv-prs
145145
/pkg/server/serverpb/ @cockroachdb/obs-inf-prs @cockroachdb/server-prs
@@ -193,7 +193,7 @@
193193
/pkg/gen/*.bzl @cockroachdb/dev-inf-noreview
194194
/pkg/gen/gen.bzl @cockroachdb/dev-inf
195195

196-
/pkg/acceptance/ @cockroachdb/sql-experience
196+
/pkg/acceptance/ @cockroachdb/sql-sessions
197197
/pkg/base/ @cockroachdb/unowned @cockroachdb/kv-prs @cockroachdb/server-prs
198198
/pkg/bench/ @cockroachdb/sql-queries-noreview
199199
/pkg/bench/rttanalysis @cockroachdb/sql-schema
@@ -224,30 +224,30 @@
224224
/pkg/ccl/testccl/workload/schemachange/ @cockroachdb/sql-schema
225225
/pkg/ccl/testutilsccl/ @cockroachdb/test-eng-noreview
226226
/pkg/ccl/utilccl/ @cockroachdb/unowned @cockroachdb/server-prs
227-
/pkg/ccl/workloadccl/ @cockroachdb/sql-experience-noreview @cockroachdb/test-eng
228-
/pkg/ccl/benchccl/rttanalysisccl/ @cockroachdb/sql-experience
227+
/pkg/ccl/workloadccl/ @cockroachdb/sql-sessions-noreview @cockroachdb/test-eng
228+
/pkg/ccl/benchccl/rttanalysisccl/ @cockroachdb/sql-schema
229229
/pkg/clusterversion/ @cockroachdb/kv-prs-noreview
230230
/pkg/cmd/allocsim/ @cockroachdb/kv-prs
231231
/pkg/cmd/bazci/ @cockroachdb/dev-inf
232232
/pkg/cmd/cloudupload/ @cockroachdb/dev-inf
233233
/pkg/cmd/cmdutil/ @cockroachdb/dev-inf
234-
/pkg/cmd/cmp-protocol/ @cockroachdb/sql-experience
235-
/pkg/cmd/cmp-sql/ @cockroachdb/sql-experience
236-
/pkg/cmd/cmpconn/ @cockroachdb/sql-experience
234+
/pkg/cmd/cmp-protocol/ @cockroachdb/sql-sessions
235+
/pkg/cmd/cmp-sql/ @cockroachdb/sql-sessions
236+
/pkg/cmd/cmpconn/ @cockroachdb/sql-sessions
237237
/pkg/cmd/cockroach/ @cockroachdb/cli-prs
238238
/pkg/cmd/cockroach-oss/ @cockroachdb/cli-prs
239239
/pkg/cmd/cockroach-short/ @cockroachdb/cli-prs
240-
/pkg/cmd/cockroach-sql/ @cockroachdb/sql-experience @cockroachdb/cli-prs
240+
/pkg/cmd/cockroach-sql/ @cockroachdb/sql-sessions @cockroachdb/cli-prs
241241
/pkg/cmd/compile-build/ @cockroachdb/dev-inf
242-
/pkg/cmd/cr2pg/ @cockroachdb/sql-experience
242+
/pkg/cmd/cr2pg/ @cockroachdb/sql-sessions
243243
/pkg/cmd/dev/ @cockroachdb/dev-inf
244244
/pkg/cmd/docgen/ @cockroachdb/docs
245245
/pkg/cmd/docs-issue-generation/ @cockroachdb/dev-inf
246246
/pkg/cmd/fuzz/ @cockroachdb/test-eng
247-
/pkg/cmd/generate-binary/ @cockroachdb/sql-experience
247+
/pkg/cmd/generate-binary/ @cockroachdb/sql-sessions
248248
/pkg/cmd/generate-distdir/ @cockroachdb/dev-inf
249249
/pkg/cmd/generate-logictest/ @cockroachdb/dev-inf
250-
/pkg/cmd/generate-metadata-tables/ @cockroachdb/sql-experience
250+
/pkg/cmd/generate-metadata-tables/ @cockroachdb/sql-sessions
251251
/pkg/cmd/generate-spatial-ref-sys/ @cockroachdb/geospatial
252252
/pkg/cmd/generate-bazel-extra/ @cockroachdb/dev-inf
253253
/pkg/cmd/generate-staticcheck/ @cockroachdb/dev-inf
@@ -279,7 +279,7 @@
279279
/pkg/cmd/roachtest/tests @cockroachdb/test-eng-noreview
280280
/pkg/cmd/roachvet/ @cockroachdb/dev-inf
281281
/pkg/cmd/skip-test/ @cockroachdb/test-eng
282-
/pkg/cmd/skiperrs/ @cockroachdb/sql-experience
282+
/pkg/cmd/skiperrs/ @cockroachdb/sql-sessions
283283
/pkg/cmd/skipped-tests/ @cockroachdb/test-eng
284284
/pkg/cmd/smith/ @cockroachdb/sql-queries
285285
/pkg/cmd/smithcmp/ @cockroachdb/sql-queries
@@ -289,11 +289,11 @@
289289
/pkg/cmd/uptodate/ @cockroachdb/dev-inf
290290
/pkg/cmd/urlcheck/ @cockroachdb/docs
291291
/pkg/cmd/whoownsit/ @cockroachdb/test-eng
292-
/pkg/cmd/workload/ @cockroachdb/sql-experience-noreview @cockroachdb/test-eng
292+
/pkg/cmd/workload/ @cockroachdb/sql-sessions-noreview @cockroachdb/test-eng
293293
/pkg/cmd/wraprules/ @cockroachdb/obs-inf-prs-noreview
294294
/pkg/cmd/zerosum/ @cockroachdb/kv-noreview
295295
/pkg/col/ @cockroachdb/sql-queries
296-
/pkg/compose/ @cockroachdb/sql-experience
296+
/pkg/compose/ @cockroachdb/sql-sessions
297297
/pkg/config/ @cockroachdb/kv-prs @cockroachdb/server-prs
298298
/pkg/docs/ @cockroachdb/docs
299299
/pkg/featureflag/ @cockroachdb/cli-prs-noreview
@@ -343,7 +343,7 @@
343343
/pkg/rpc/auth.go @cockroachdb/unowned @cockroachdb/server-prs @cockroachdb/kv-prs @cockroachdb/prodsec
344344
/pkg/scheduledjobs/ @cockroachdb/jobs-prs
345345
/pkg/security/ @cockroachdb/unowned @cockroachdb/server-prs @cockroachdb/prodsec
346-
/pkg/security/clientsecopts/ @cockroachdb/unowned @cockroachdb/server-prs @cockroachdb/sql-experience @cockroachdb/prodsec
346+
/pkg/security/clientsecopts/ @cockroachdb/unowned @cockroachdb/server-prs @cockroachdb/sql-sessions @cockroachdb/prodsec
347347
/pkg/settings/ @cockroachdb/unowned
348348
/pkg/spanconfig/ @cockroachdb/kv-prs
349349
/pkg/repstream/ @cockroachdb/disaster-recovery
@@ -362,7 +362,7 @@
362362
/pkg/util/admission/ @cockroachdb/admission-control
363363
/pkg/util/schedulerlatency/ @cockroachdb/admission-control
364364
/pkg/util/tracing @cockroachdb/obs-inf-prs
365-
/pkg/workload/ @cockroachdb/sql-experience-noreview @cockroachdb/test-eng
365+
/pkg/workload/ @cockroachdb/sql-sessions-noreview @cockroachdb/test-eng
366366
/pkg/obs/ @cockroachdb/obs-inf-prs
367367
/pkg/obsservice/ @cockroachdb/obs-inf-prs
368368

‎TEAMS.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@
1919

2020
cockroachdb/docs:
2121
triage_column_id: 3971225
22-
cockroachdb/sql-experience:
22+
cockroachdb/sql-sessions:
2323
aliases:
2424
cockroachdb/sql-syntax-prs: other
2525
cockroachdb/sqlproxy-prs: other
2626
cockroachdb/sql-api-prs: other
2727
triage_column_id: 7259065
28-
label: T-sql-experience
28+
label: T-sql-sessions
2929
cockroachdb/sql-schema:
3030
triage_column_id: 8946818
3131
cockroachdb/sql-queries:

‎pkg/cmd/roachtest/registry/owners.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ type Owner string
1616

1717
// The allowable values of Owner.
1818
const (
19-
OwnerSQLExperience Owner = `sql-experience`
19+
OwnerSQLExperience Owner = `sql-sessions`
2020
OwnerDisasterRecovery Owner = `disaster-recovery`
2121
OwnerCDC Owner = `cdc`
2222
OwnerKV Owner = `kv`

‎pkg/sql/parser/sql.y‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15032,7 +15032,7 @@ interval_value:
1503215032
$$.val = &tree.CastExpr{
1503315033
Expr: tree.NewStrVal($2),
1503415034
Type: t,
15035-
// TODO(#sql-experience): This should be CastPrepend, but
15035+
// TODO(#sql-sessions): This should be CastPrepend, but
1503615036
// that does not work with parenthesized expressions
1503715037
// (using FmtAlwaysGroupExprs).
1503815038
SyntaxMode: tree.CastShort,
@@ -15050,7 +15050,7 @@ interval_value:
1505015050
Type: types.MakeInterval(
1505115051
types.IntervalTypeMetadata{Precision: prec, PrecisionIsSet: true},
1505215052
),
15053-
// TODO(#sql-experience): This should be CastPrepend, but
15053+
// TODO(#sql-sessions): This should be CastPrepend, but
1505415054
// that does not work with parenthesized expressions
1505515055
// (using FmtAlwaysGroupExprs).
1505615056
SyntaxMode: tree.CastShort,

‎pkg/sql/sem/tree/constant.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ func (expr *NumVal) ResolveAsType(
345345
if strings.EqualFold(expr.origString, "NaN") {
346346
// We need to check NaN separately since expr.value is
347347
// unknownVal for NaN.
348-
// TODO(sql-experience): unknownVal is also used for +Inf and
348+
// TODO(sql-sessions): unknownVal is also used for +Inf and
349349
// -Inf, so we may need to handle those in the future too.
350350
expr.resFloat = DFloat(math.NaN())
351351
} else {

‎pkg/util/tochar/tochar.go‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,6 @@ func (d dchSuffix) zeroPad2PlusNeg(val int) int {
599599
// parseFormat matches parse_format. We do not take in a flags like PG as we only do
600600
// datetime related items (the logic here will change if we support numeric types).
601601
// Taken from https://github.com/postgres/postgres/blob/b0b72c64a0ce7bf5dd78a80b33d85c89c943ad0d/src/backend/utils/adt/formatting.c#L1146.
602-
// TODO(#sql-experience): consider caching parse formats.
603602
func parseFormat(f string) []formatNode {
604603
var ret []formatNode
605604
for len(f) > 0 {

0 commit comments

Comments
 (0)