sqlinstance: make Start async, use in-memory copy of self to bootstrap#92666
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 29, 2022
Merged
Conversation
This solves bullet 4 of cockroachdb#85737. This commit makes sqlinstance.Start async, and not block until the rangefeed gets started. Epic: CRDB-18596 Release note: None Co-authored-by: Andrew Werner <awerner32@gmail.com>
b4fa8d9 to
e90c549
Compare
Contributor
Author
|
TFTR! bors r=ajwerner |
Contributor
|
Build succeeded: |
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this pull request
Dec 3, 2022
In cockroachdb#92666 we stopped waiting for the sqlinstance.Reader to know about all the other instances synchronously at startup. Waiting for this information requires out-of-region RPCs. The hazard here is that in the temp table tests which lower the grace period for temp tables dramatically, we might delete temp tables which should not be deleted. By waiting for these instances, we deflake the test. Epic: none Fixes: cockroachdb#92895 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Dec 5, 2022
92993: server,sql: ensure that temp tables wait to know about other instances r=ajwerner a=ajwerner In #92666 we stopped waiting for the sqlinstance.Reader to know about all the other instances synchronously at startup. Waiting for this information requires out-of-region RPCs. The hazard here is that in the temp table tests which lower the grace period for temp tables dramatically, we might delete temp tables which should not be deleted. By waiting for these instances, we deflake the test. Epic: none Fixes: #92895 Release note: None Co-authored-by: Andrew Werner <awerner32@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves bullet 4 of #85737. This commit makes sqlinstance.Start async, and
not block until the rangefeed gets started.
Epic: CRDB-18596
Release note: None