server,sql: ensure that temp tables wait to know about other instances#92993
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 5, 2022
Merged
Conversation
In cockroachdb#92666 we stopped waiting for the sqlinstance.Reader to know about all the other instances synchronously at startup. Waiting for this information requires out-of-region RPCs. The hazard here is that in the temp table tests which lower the grace period for temp tables dramatically, we might delete temp tables which should not be deleted. By waiting for these instances, we deflake the test. Epic: none Fixes: cockroachdb#92895 Release note: None
Member
|
This change is |
postamar
approved these changes
Dec 5, 2022
postamar
left a comment
There was a problem hiding this comment.
This change seems reasonable; however, I'm not an expert in this area.
Contributor
Author
|
I'll take it. bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #92666 we stopped waiting for the sqlinstance.Reader to know about all the other instances synchronously at startup. Waiting for this information requires out-of-region RPCs. The hazard here is that in the temp table tests which lower the grace period for temp tables dramatically, we might delete temp tables which should not be deleted. By waiting for these instances, we deflake the test.
Epic: none
Fixes: #92895
Release note: None