roachtest: disable decimal columns in costfuzz and unoptimized tests#89200
roachtest: disable decimal columns in costfuzz and unoptimized tests#89200craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
michae2
left a comment
There was a problem hiding this comment.
Thanks!
Does this also handle decimal columns in CREATE TABLE statements? It looks like the various randTables functions in setup.go are calling into randgen.RandCreateTables which doesn't seem to use these type-generating functions?
Could you also add DisableDecimals as an option to smith here? Thank you!
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @mgartner and @msirek)
The use of decimal columns was making costfuzz and unoptimized-query-oracle tests flaky. This commit disables generation of decimal columns as a temporary mitigation for these flakes. Fixes cockroachdb#88547 Release note: None
d51c834 to
37a0080
Compare
|
TFTR!
No, I don't think this changes anything about the
Done. |
michae2
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
|
TFTR! bors r+ |
|
Build succeeded: |
|
blathers backport 22.2.0 |
This commit fixes an oversight from cockroachdb#89200 which failed to disable decimals in one case that was making costfuzz and unoptimized-query-oracle tests flaky. Fixes cockroachdb#89303 Release note: None
89449: roachtest: disable decimal columns in costfuzz and unoptimized tests r=rytaft a=rytaft This commit fixes an oversight from #89200 which failed to disable decimals in one case that was making costfuzz and unoptimized-query-oracle tests flaky. Fixes #89303 Release note: None Co-authored-by: Rebecca Taft <becca@cockroachlabs.com>
The use of decimal columns was making costfuzz and unoptimized-query-oracle tests flaky. This commit disables generation of decimal columns as a temporary mitigation for these flakes.
Fixes #88547
Release note: None