roachtest: disable decimal columns in costfuzz and unoptimized tests#89449
roachtest: disable decimal columns in costfuzz and unoptimized tests#89449craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This commit fixes an oversight from cockroachdb#89200 which failed to disable decimals in one case that was making costfuzz and unoptimized-query-oracle tests flaky. Fixes cockroachdb#89303 Release note: None
|
This change is |
DrewKimball
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
msirek
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/internal/sqlsmith/type.go line 48 at r1 (raw file):
case types.DecimalFamily: if s.disableDecimals { typ = s.randType()
The calls to RandColumnType in makeAlterColumnType and makeAddColumn probably need modification as well.
There is also randColumnTableDef in randgen.
rytaft
left a comment
There was a problem hiding this comment.
TFTRs!
I’m going to go ahead and merge this to hopefully avoid more flakes tonight
bors r+
Reviewable status:
pkg/internal/sqlsmith/type.go line 48 at r1 (raw file):
Previously, msirek (Mark Sirek) wrote…
The calls to
RandColumnTypeinmakeAlterColumnTypeandmakeAddColumnprobably need modification as well.
There is alsorandColumnTableDefin randgen.
I’m not actually worried about the DDL— I think it’s ok if the table columns are decimal as long as they don’t get returned in the query
|
Build succeeded: |
This commit fixes an oversight from #89200 which failed to disable decimals in one case that was making costfuzz and unoptimized-query-oracle tests flaky.
Fixes #89303
Release note: None