clisqlshell: hide the libedit dep behind a go interface#88574
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 3, 2022
Merged
clisqlshell: hide the libedit dep behind a go interface#88574craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
aac2daa to
d5449c8
Compare
ZhouXing19
approved these changes
Nov 3, 2022
Collaborator
ZhouXing19
left a comment
There was a problem hiding this comment.
Very cool improvement! It makes the code much easier to read.
rafiss
reviewed
Nov 3, 2022
| "github.com/cockroachdb/errors" | ||
| ) | ||
|
|
||
| // bufioReader implements the editor interface. |
Collaborator
There was a problem hiding this comment.
could we include declarations for the implementing types that assert that they implement the interface?
In cockroachdb#86457 and related work we will want to offer two editors side-by-side in a transition period, so folk can compare or fall back on something known in case they are not happy with the new stuff. To enable this transition period, this commit hides the editor behind a go interface. This also makes the shell code overall easier to read and understand. Release note: None
Contributor
Author
|
bors r=ZhouXing19,rafiss |
Contributor
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
86457: cli: replace libedit with bubbline r=ZhouXing19 a=knz First commit from #88574. Benefits from (but is not dependent on) #87606 server-side. Fixes #21826 Fixes #71207 Fixes #71209 Fixes #57885 NB: this will benefit from upstream library releases based off the still-unmerged PRs listed in knz/bubbline#2. Release justification: n/a will not merge before stability ends Release note (cli change): The engine used as line editor in the interactive shell (`cockroach sql`, `demo`) has been updated. It includes numerous bug fixes and new features. The previous engine can still be accessed via the env var COCKROACH_SQL_FORCE_LIBEDIT. This support will be removed in a later version. 92335: kvserver,logstore: introduce log StateLoader r=tbg a=pavelkalinnikov Previously the `StateLoader` accessed both log and state machine state. This commit moves most of the log-specific accesstors to the `logstore` package. Part of #91979 Release note: None Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net> Co-authored-by: Pavel Kalinnikov <pavel@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #86457 and related work we will want to offer two editors side-by-side in a transition period, so folk can compare or fall back on something known in case they are not happy with the new stuff.
To enable this transition period, this commit hides the editor behind a go interface.
This also makes the shell code overall easier to read and understand.
Epic: CRDB-22182
Release note: None