kvserver,logstore: introduce log StateLoader#92335
Merged
craig[bot] merged 3 commits intocockroachdb:masterfrom Dec 1, 2022
Merged
kvserver,logstore: introduce log StateLoader#92335craig[bot] merged 3 commits intocockroachdb:masterfrom
craig[bot] merged 3 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
tbg
approved these changes
Nov 23, 2022
Member
tbg
left a comment
There was a problem hiding this comment.
Mind adding Epic: CRDB-220? Something must've changed about the linter, it used to ask for an epic. 220 is our sep raft log epic.
Reviewed 6 of 6 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @pavelkalinnikov)
Contributor
Collaborator
Author
7d825e8 to
73a2d99
Compare
Previously the StateLoader accessed both log and state machine state. This commit moves most of the log-specific accesstors to the logstore package. Release note: None
Release note: None
Release note: None
73a2d99 to
e07488b
Compare
Collaborator
Author
|
bors r=tbg |
Contributor
|
Build failed: |
Collaborator
Author
|
bors retry |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
StateLoaderaccessed both log and state machine state. This commit moves most of the log-specific accesstors to thelogstorepackage.Part of #91979
Release note: None