release-21.2: ui/db-console: surface more job metrics around reverting and retrying in the DBConsole Jobs Overview page#73624
Merged
jocrl merged 1 commit intocockroachdb:release-21.2from Dec 10, 2021
Conversation
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
Member
|
This change is |
maryliag
suggested changes
Dec 8, 2021
Contributor
maryliag
left a comment
There was a problem hiding this comment.
Reviewed 19 of 21 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @jocrl and @maryliag)
pkg/server/BUILD.bazel, line 268 at r1 (raw file):
======= size = "enormous", >>>>>>> f0d0467c28 (ui/db-console: surface more job metrics around reverting and retrying in the)
looks like you missed this conflict :)
9550bdd to
255c6a6
Compare
Contributor
Author
|
pkg/server/BUILD.bazel, line 268 at r1 (raw file): Previously, maryliag (Marylia Gutierrez) wrote…
Done; thank you! |
This was referenced Dec 9, 2021
… in the DBConsole Jobs Overview page Fixes cockroachdb#68179 This commit surfaces the status `reverting`, annotates existing `running` and `reverting` statuses UI with "retrying" where applicable, and adds the "Last Execution Time (UTC)" and "Execution Count" columns to the jobs overview table in db console. "Retrying" is defined as `status IN ('running', 'reverting') AND next_run > now() AND num_runs > 1`. Hovering a retrying status shows the next execution time. The "Status" column was also moved left to the second column. Filtering using the dropdown by `Status: Running` or `Status: Reverting` will include those that are also "retrying". Users can also filter by `Status: Retrying`. The `/jobs` endpoint was modified to add the `last_run`, `next_run`, and `num_runs` fields required for the UI change. Jobs with status `running` or `reverting` and are also "retrying" have their statuses sent as `retry-running` and `retry-reverting` respectively. The endpoint was also modified to support the value `retrying` for the `status` query parameter. This commit also adds a storybook story for the jobs table, which showcases the different possible statuses in permutations of information that could be present for the `running` status. Release note (ui change): The jobs overview table in DBConsole now shows when jobs have the status "reverting", and shows the badge "retrying" when running or reverting jobs are also retrying. Hovering the status for a "retrying" job will show the "Next execution time" in UTC. Two new columns, "Last Execution Time (UTC)" and "Execution Count", were also added to the jobs overview table in DBConsole, and the "Status" column was moved left to the second column in the table. The `status` query parameter in the `/jobs` endpoint now supports the values `reverting` and `retrying`.
255c6a6 to
b826eab
Compare
jocrl
added a commit
to jocrl/cockroach
that referenced
this pull request
Mar 7, 2022
This commit fixes the stray parenthesis at the end of the duration time for a succeeded job. The parenthesis had been introduced in cockroachdb#76691 and the 21.2 backport cockroachdb#73624. Release note (ui): Remove stray parenthesis at the end of the duration time for a succeeded job. It had been accidentally introduced to unreleased master and a 21.2 backport. Release justification: Category 2, UI bug fix
jocrl
added a commit
to jocrl/cockroach
that referenced
this pull request
Mar 7, 2022
Addresses cockroachdb#77440. This commit fixes the stray parenthesis at the end of the duration time for a succeeded job. The parenthesis had been introduced in cockroachdb#76691 and the 21.2 backport cockroachdb#73624. Release note (ui): Remove stray parenthesis at the end of the duration time for a succeeded job. It had been accidentally introduced to unreleased master and a 21.2 backport. Release justification: Category 2, UI bug fix
craig bot
pushed a commit
that referenced
this pull request
Mar 7, 2022
77208: sql: update test that was fooling itself r=ajwerner a=ajwerner I have no clue what is going on in #76843 but this test was fooling itself regarding the existence of separate connections. Release justification: non-production code changes Release note: None 77220: sql/contention/txnidcache: reuse blocks in list, account for space r=maryliag,ajwerner a=ajwerner This change does two things to the txnidcache: 1) It accounts for the space used by the fifo eviction list. Previously we'd use more than double the intended space. We should probably also subtrace out the size of the buffers we're currently filling and the channel we use to communicate them, but I'll leave that for later. 2) It stops trying to compact the blocks. Compacting the blocks ends up being a good deal of overhead because we have to copy across every single message. Instead we can just append the block directly to the list. This does have the hazard of wasting a lot of space when the blocks are sparse. However, if the blocks are sparse, we know that the throughput is low, so it's fine. Resolves #76738 Release justification: bug fixes and low-risk updates to new functionality Release note: None 77363: sql/delegate: avoid extra string->int parsing r=otan a=rafiss Release justification: low risk improvement Release note: None 77438: ui: Remove stray parenthesis in Jobs page r=jocrl a=jocrl Addresses #77440. This commit fixes the stray parenthesis at the end of the duration time for a succeeded job. The parenthesis had been introduced in #76691 and the 21.2 backport #73624. Before:  After:  Release note (ui): Remove stray parenthesis at the end of the duration time for a succeeded job. It had been accidentally introduced to unreleased master and a 21.2 backport. Release justification: Category 2, UI bug fix Co-authored-by: Andrew Werner <awerner32@gmail.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Josephine Lee <josephine@cockroachlabs.com>
jocrl
added a commit
to jocrl/cockroach
that referenced
this pull request
Mar 7, 2022
Addresses cockroachdb#77440. This commit fixes the stray parenthesis at the end of the duration time for a succeeded job. The parenthesis had been introduced in cockroachdb#76691 and the 21.2 backport cockroachdb#73624. Release note (ui): Remove stray parenthesis at the end of the duration time for a succeeded job. It had been accidentally introduced to unreleased master and a 21.2 backport. Release justification: Category 2, UI bug fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #72291.
/cc @cockroachdb/release
Fixes #68179
This commit surfaces the status
reverting, annotates existingrunningandrevertingstatuses UI with "retrying" where applicable, and adds the "LastExecution Time (UTC)" and "Execution Count" columns to the jobs overview table
in db console. "Retrying" is defined as
status IN ('running', 'reverting') AND next_run > now() AND num_runs > 1.Hovering a retrying status shows the next execution time. The "Status" column
was also moved left to the second column. Filtering using the dropdown by
Status: RunningorStatus: Revertingwill include those that arealso "retrying". Users can also filter by
Status: Retrying.The
/jobsendpoint was modified to add thelast_run,next_run, andnum_runsfields required for the UI change. Jobs with statusrunningorrevertingand are also "retrying" have their statuses sent asretry-runningand
retry-revertingrespectively. The endpoint was also modified to supportthe value
retryingfor thestatusquery parameter.This commit also adds a storybook story for the jobs table, which showcases the
different possible statuses in permutations of information that could be
present for the
runningstatus.Release note (ui change): The jobs overview table in DBConsole now shows when
jobs have the status "reverting", and shows the badge "retrying" when running
or reverting jobs are also retrying. Hovering the status for a "retrying" job
will show the "Next execution time" in UTC. Two new columns, "Last Execution
Time (UTC)" and "Execution Count", were also added to the jobs overview table
in DBConsole, and the "Status" column was moved left to the second column in
the table.
The
statusquery parameter in the/jobsendpoint now supports the valuesrevertingandretrying.Release justification: Category 4, UI change
Jobs table:
Filter and hover:
https://user-images.githubusercontent.com/91907326/141375153-2cf2641a-33a1-4bfb-a900-a187dc5579a1.mov
Permutations of running jobs with present/absent combinations of time remaining, running message, or retrying:
