Skip to content

ui: Remove stray parenthesis in Jobs page#77438

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
jocrl:fix-stray-parenthesis
Mar 7, 2022
Merged

ui: Remove stray parenthesis in Jobs page#77438
craig[bot] merged 1 commit intocockroachdb:masterfrom
jocrl:fix-stray-parenthesis

Conversation

@jocrl
Copy link
Copy Markdown
Contributor

@jocrl jocrl commented Mar 7, 2022

Addresses #77440.

This commit fixes the stray parenthesis at the end of the duration time for a
succeeded job. The parenthesis had been introduced in
#76691 and the 21.2 backport
#73624.

Before:
image

After:
image

Release note (ui): Remove stray parenthesis at the end of the duration time for
a succeeded job. It had been accidentally introduced to unreleased master and a
21.2 backport.

Release justification: Category 2, UI bug fix

@jocrl jocrl requested a review from a team March 7, 2022 15:37
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@jocrl jocrl force-pushed the fix-stray-parenthesis branch from 3b94af8 to a66c761 Compare March 7, 2022 15:38
@jocrl
Copy link
Copy Markdown
Contributor Author

jocrl commented Mar 7, 2022


-- commits, line 4 at r1:
I assumed I don't need to make an issue for this, and didn't do so.

Copy link
Copy Markdown
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)

Addresses  cockroachdb#77440.

This commit fixes the stray parenthesis at the end of the duration time for a
succeeded job. The parenthesis had been introduced in
cockroachdb#76691 and the 21.2 backport
cockroachdb#73624.

Release note (ui): Remove stray parenthesis at the end of the duration time for
a succeeded job. It had been accidentally introduced to unreleased master and a
21.2 backport.

Release justification: Category 2, UI bug fix
@jocrl jocrl force-pushed the fix-stray-parenthesis branch from a66c761 to cce5695 Compare March 7, 2022 15:55
@jocrl
Copy link
Copy Markdown
Contributor Author

jocrl commented Mar 7, 2022

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 7, 2022

Build succeeded:

@craig craig bot merged commit b5bbbed into cockroachdb:master Mar 7, 2022
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Mar 7, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating backport branch refs/heads/blathers/backport-release-21.2-77438: POST https://api.github.com/repos/cockroachlabs/cockroach/git/refs: 403 Resource not accessible by integration []

Backport to branch 21.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants