Skip to content

jobs: follow pattern to use the background context#72651

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20211111-jobs-pattern
Nov 11, 2021
Merged

jobs: follow pattern to use the background context#72651
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20211111-jobs-pattern

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Nov 11, 2021

Improves #72605.
Informs #58938.

  • (*AmbientContext).AnnotateCtx() - takes care of connecting the
    context to the tracer
  • logtags.FromContext / logtags.WithTags - reproduces the logging
    tags on the child context.

Release note: None

@knz knz requested review from ajwerner and miretskiy November 11, 2021 17:44
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

craig bot pushed a commit that referenced this pull request Nov 11, 2021
72638: catalog/lease: avoid using context.Background directly r=ajwerner a=knz

First commit from #72651
Informs #58938.

- `(*AmbientContext).AnnotateCtx()` - takes care of connecting the
  context to the tracer
- `logtags.FromContext` / `logtags.WithTags` - reproduces the logging
  tags on the child context.

Release note: None

72640: sql/types: types.EnumMetadata implements encoding.TextMarshaler interface r=chengxiong-ruan a=chengxiong-ruan

Fixes #63379

`types.EnumMetadata` needs to implement `encoding.TextMarshaler`
interface so that goto/protobuf won't panic when text marshaling
protobuf struct has child field of type `types.EnumMetadata`.
See the issue for more details why it would fail without this
fix.

Release note: None

72644: server: improve the tenant context r=RaduBerinde a=knz

All commits but the last from #72638
(Reviewers: only review last commit)

Informs #58938

72647: admission,server: context improvements r=RaduBerinde a=knz

All commits but the last 2 from  #72644
(Reviewers: only review last 2 commits)

Informs #58938

72650: streamingest: wait for all goroutines on streamIngestProcessor shutdown  r=andreimatei a=andreimatei

This processor was failing to stop and wait for some of the goroutines it
spawned, which is not nice (in particular, it's likely that those
goroutines were using a tracing span after it was finished).

Release note: None

72652: internal/sqlsmith: do not use crdb_internal.start_replication_stream r=yuzefovich a=yuzefovich

Fixes: #72633.
Fixes: #72634.

Release note: None

72661: migration: add missing leaktests r=andreimatei a=andreimatei

Release note: None

72668: roachtest: add assignment-cast related failures to pgjdbc r=RichardJCai a=rafiss

fixes #72636

Release note: None

Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Co-authored-by: Chengxiong Ruan <chengxiong@cockroachlabs.com>
Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
@craig craig bot merged commit 8d69380 into cockroachdb:master Nov 11, 2021
@knz knz deleted the 20211111-jobs-pattern branch November 12, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants