admission,server: context improvements#72647
Merged
craig[bot] merged 6 commits intocockroachdb:masterfrom Nov 11, 2021
Merged
Conversation
Member
|
This change is |
RaduBerinde
approved these changes
Nov 11, 2021
Member
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @stevendanna)
Release note: None
- `(*AmbientContext).AnnotateCtx()` - takes care of connecting the context to the tracer - `logtags.FromContext` / `logtags.WithTags` - reproduces the logging tags on the child context. Release note: None
Release note: None
Release note: None
Release note: None
This ensures the activity is present in traces, logs, etc and that the server IDs are properly reported. Release note: None
98c4f1e to
465c8ea
Compare
Contributor
Author
|
bors r=RaduBerinde |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All commits but the last 2 from #72644
(Reviewers: only review last 2 commits)
Informs #58938