backupccl: create more chunks on larger clusters#64067
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 23, 2021
Merged
backupccl: create more chunks on larger clusters#64067craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This change updates the chunk size to take larger clusters into account. On larger clusters, having more chunks (that are each smaller) is beneficial because this results in more even load after scattering these chunks. Release note: None
Member
|
This change is |
Contributor
Author
|
Anecdotally it looks like this change helps reduce the discrepancy between when the processors finish processing their AddSSTable requests. Will run some before/after restore2TBs to see if there's a meaningful reduction in the variance of the test runs. |
dt
approved these changes
Apr 22, 2021
adityamaru
approved these changes
Apr 23, 2021
Contributor
Author
|
This looks to do good things. Before: After: |
Contributor
Author
|
TFTRs! |
Contributor
|
Build succeeded: |
This was referenced May 4, 2021
craig bot
pushed a commit
that referenced
this pull request
May 17, 2021
64656: release-21.1: improve restore performance consistency r=dt a=pbardea Backport: * 2/2 commits from "backupccl: rework split and scatter mechanism" (#63471) * 1/1 commits from "backupccl: fix a bug in routing scattered ranges" (#63875) * 1/1 commits from "backupccl: create more chunks on larger clusters" (#64067) Please see individual PRs for details. /cc @cockroachdb/release Added do-not-merge label until release-21.1 opens for 21.1.1 backports once the release is out. Co-authored-by: Paul Bardea <pbardea@gmail.com>
This was referenced May 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the chunk size to take larger clusters into account.
On larger clusters, having more chunks (that are each smaller) is
beneficial because this results in more even load after scattering these
chunks.
Release note: None