backupccl: fix a bug in routing scattered ranges#63875
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 22, 2021
Merged
backupccl: fix a bug in routing scattered ranges#63875craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This change fixes a bug in the planning of the restore DistSQL flow. The ordering of the source router slots did not match the order that the streams were added to the range router. This meant that the range router could mis-direct rows in the flow to the incorrect node. Ever after this change, it appears that a lot of AddSSTables are not handled locally and so the release note does not indicate any performance improvement. Release note: None
Member
|
This change is |
adityamaru
approved these changes
Apr 20, 2021
Contributor
adityamaru
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @pbardea)
Contributor
|
Nice catch! |
Contributor
Author
|
TFTR |
Contributor
|
Build succeeded: |
This was referenced May 4, 2021
craig bot
pushed a commit
that referenced
this pull request
May 17, 2021
64656: release-21.1: improve restore performance consistency r=dt a=pbardea Backport: * 2/2 commits from "backupccl: rework split and scatter mechanism" (#63471) * 1/1 commits from "backupccl: fix a bug in routing scattered ranges" (#63875) * 1/1 commits from "backupccl: create more chunks on larger clusters" (#64067) Please see individual PRs for details. /cc @cockroachdb/release Added do-not-merge label until release-21.1 opens for 21.1.1 backports once the release is out. Co-authored-by: Paul Bardea <pbardea@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a bug in the planning of the restore DistSQL flow. The
ordering of the source router slots did not match the order that the
streams were added to the range router. This meant that the range router
could mis-direct rows in the flow to the incorrect node.
Ever after this change, it appears that a lot of AddSSTables are not
handled locally and so the release note does not indicate any
performance improvement.
Release note: None