util/log: new JSON output formats#58126
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 31, 2020
Merged
Conversation
Member
|
This change is |
26 tasks
53dcf5e to
e178bb5
Compare
e178bb5 to
475f3d5
Compare
475f3d5 to
b837842
Compare
craig bot
pushed a commit
that referenced
this pull request
Dec 28, 2020
58031: util/log: delay the formatting of log entries r=itsbilal a=knz Needed for #58126 Prior to this patch, the logging events were converted to a `logpb.Entry` very early in the logging pipeline. This was forcing the conversion of the logging tags to a flat string too early, and making it hard for (e.g.) a JSON formatter to preserve the structure of logging tags. This patch averts this by introducing a new `logEntry` type which has more-or-less the same structure as `logpb.Entry` but keep the logging tags structured until the point the entry is formatted. Release note: None Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
b837842 to
11e6f0a
Compare
itsbilal
approved these changes
Dec 30, 2020
Contributor
itsbilal
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, 6 of 6 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained
Release note (cli change): It is now possible to set the `format` parameter of any log sink, including file sinks, to `json`, `json-compact`, `json-fluent` or `json-fluent-compact` to write entries as structured JSON. Refer to the linked reference documentation for details.
11e6f0a to
cebda3f
Compare
Contributor
Author
|
thanks! bors r=itsbilal |
Contributor
|
Build succeeded! And happy new year! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44755
(This code was extracted from #57170 to further simplify it.)
Release note (cli change): It is now possible to set the
formatparameter of any log sink, including file sinks, to
json,json-compact,json-fluentorjson-fluent-compactto writeentries as structured JSON. Refer to the linked reference
documentation for details.