util/log: delay the formatting of log entries#58031
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 28, 2020
Merged
util/log: delay the formatting of log entries#58031craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
dc69a2b to
39a4b4f
Compare
b3471b6 to
14d01f0
Compare
d289642 to
41a572e
Compare
Contributor
Author
|
I am aware of a CI failure which is going to be fixed by a dep bump: cockroachdb/redact#14 |
e1ce16b to
aff65d3
Compare
Prior to this patch, the logging events were converted to a `logpb.Entry` very early in the logging pipeline. This was forcing the conversion of the logging tags to a flat string too early, and making it hard for (e.g.) a JSON formatter to preserve the structure of logging tags. This patch averts this by introducing a new `logEntry` type which has more-or-less the same structure as `logpb.Entry` but keep the logging tags structured until the point the entry is formatted. Release note: None
aff65d3 to
a74b36a
Compare
itsbilal
approved these changes
Dec 28, 2020
Contributor
itsbilal
left a comment
There was a problem hiding this comment.
Reviewed 21 of 21 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
Contributor
Author
|
thanks! bors r=itsbilal |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for #58126
Prior to this patch, the logging events were converted to a
logpb.Entryvery early in the logging pipeline. This was forcing theconversion of the logging tags to a flat string too early, and making
it hard for (e.g.) a JSON formatter to preserve the structure of
logging tags.
This patch averts this by introducing a new
logEntrytype which hasmore-or-less the same structure as
logpb.Entrybut keep the loggingtags structured until the point the entry is formatted.
Release note: None