Skip to content

Properly handle nil SafeMessagers#14

Merged
knz merged 1 commit intomasterfrom
20201218-warning
Dec 21, 2020
Merged

Properly handle nil SafeMessagers#14
knz merged 1 commit intomasterfrom
20201218-warning

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Dec 18, 2020

I was investigating a CI failure in cockroachdb/cockroach#58031

and found this bug.


This change is Reviewable

@knz knz requested a review from irfansharif December 18, 2020 20:30
@knz knz force-pushed the 20201218-warning branch from d80bf5c to 4b97319 Compare December 18, 2020 20:51
@knz knz requested a review from ajwerner December 18, 2020 20:51
@knz knz force-pushed the 20201218-warning branch from 4b97319 to 5d5f479 Compare December 18, 2020 20:52
@knz knz changed the title Additional testing for panic-inducing code. Properly handle nil SafeMessagers Dec 18, 2020
@knz knz requested review from tbg and removed request for ajwerner and irfansharif December 21, 2020 08:42
@knz knz merged commit 16f07ec into master Dec 21, 2020
@irfansharif irfansharif deleted the 20201218-warning branch December 21, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants