jobs: allow Reverting jobs to have status and progress updates#45096
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 13, 2020
Merged
jobs: allow Reverting jobs to have status and progress updates#45096craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Previously only `Running` jobs could have their status and progress updated. This PR updates `JobMetadata.CheckRunning()` to also allow those updates on `Reverting` jobs, as part of bringing the contract of reverting jobs in line with running jobs. Release note: None
Member
|
This change is |
spaskob
approved these changes
Feb 13, 2020
Contributor
spaskob
left a comment
There was a problem hiding this comment.
thanks!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @spaskob)
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Feb 13, 2020
45096: jobs: allow Reverting jobs to have status and progress updates r=lucy-zhang a=lucy-zhang Previously only `Running` jobs could have their status and progress updated. This PR updates `JobMetadata.CheckRunning()` to also allow those updates on `Reverting` jobs, as part of bringing the contract of reverting jobs in line with running jobs. Release note: None Co-authored-by: Lucy Zhang <lucy-zhang@users.noreply.github.com>
Contributor
Build succeeded |
spaskob
added a commit
to spaskob/cockroach
that referenced
this pull request
Feb 19, 2020
In the test there is a race condition between checking that job cannot update progress and switchinbg the job to status Reverting. I removed the check as it is unnecessary since we already check in the end of the test that the job is marked as Canceled. In the future is advisable to stress test all PRs that touch jobs infrastructure. Fixes cockroachdb#45131, Fixes cockroachdb#45204. Release note: none.
craig bot
pushed a commit
that referenced
this pull request
Feb 20, 2020
45208: jobs: fix flake introduced by #45096 r=spaskob a=spaskob In the test there is a race condition between checking that job cannot update progress and switching the job to status Reverting. I removed the check as it is unnecessary since we already check in the end of the test that the job is marked as Canceled. In the future it is advisable to stress test all PRs that touch jobs infrastructure to avoid flakes. Fixes #45131. Fixes #45204. Release note: none. Co-authored-by: Spas Bojanov <pachob@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously only
Runningjobs could have their status and progress updated.This PR updates
JobMetadata.CheckRunning()to also allow those updates onRevertingjobs, as part of bringing the contract of reverting jobs in linewith running jobs.
Release note: None