jobs: fix flake introduced by #45096#45208
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 20, 2020
Merged
Conversation
In the test there is a race condition between checking that job cannot update progress and switchinbg the job to status Reverting. I removed the check as it is unnecessary since we already check in the end of the test that the job is marked as Canceled. In the future is advisable to stress test all PRs that touch jobs infrastructure. Fixes cockroachdb#45131, Fixes cockroachdb#45204. Release note: none.
Member
|
This change is |
thoszhang
approved these changes
Feb 20, 2020
thoszhang
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
Contributor
Author
|
bors r+ |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the test there is a race condition between
checking that job cannot update progress and
switching the job to status Reverting. I removed
the check as it is unnecessary since we already
check in the end of the test that the job is marked
as Canceled.
In the future it is advisable to stress test all PRs
that touch jobs infrastructure to avoid flakes.
Fixes #45131.
Fixes #45204.
Release note: none.