roachtest: adjust tpchvec test#44365
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 27, 2020
Merged
Conversation
This commit adds the print out of all vec ON and vec OFF times if the test is failed because of slow vec ON performance. Also, in order to reduce noise, we now require that the best vec ON time is worse than the best vec OFF time. This addresses a case when a query has two fast runtimes and two slow ones (I don't know why it happens, but sometimes the first two runs of a query, especially with a small order number like Q3, will be slow with vec ON). Release note: None
Member
asubiotto
approved these changes
Jan 27, 2020
Contributor
asubiotto
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
Member
Author
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jan 27, 2020
42522: colexec: add unordered distinct r=yuzefovich a=yuzefovich **distsql: add a test comparing distinct operator and processor** Release note: None **colexec: minor cleanup of hashjoiner_tmpl** This commit removes some extra empty lines from the generated code by appending `-` to the end of the template definitions. Also, it refactors one conditional into an assignment. Release note: None **colexec: fix a bug in hash table when null equality is allowed** Previously we incorrectly were handling the case of allowed null equality in the hash table (which is used by the hash grouper and unordered distinct) - we were resetting groupID of the tuple on the probe side of that tuple has NULL value in the equality column whereas the build tuple has a non-NULL value. This could result in incorrectly populated `same` array and is now fixed. Release note: None **colexec: add unordered distinct** This commit adds an unordered distinct operator. The operator simply builds a hashTable on the first call to Next() on the whole input, then iterates over all of the tuples to check whether the tuple is the "head" of a linked list that contain all of the tuples that are equal on distinct columns. Only the "head" is included into the big selection vector. Once the big selection vector is populated, the operator proceeds to returning the batches according to a chunk of the selection vector. This doesn't take into account whether the input is partially ordered, and this item is left as a follow-up work. Fixes: #39240. Release note (sql change): vectorized execution engine now supports DISTINCT on unordered input. **colexec: fix hash grouper** Previously, hash grouper could hit an internal error of index outside of range when it was looking for the "head" of a linked list. Now this is fixed by refactoring the code in question. I think the code is now more comprehensible. There is no release note since hash grouper so far has been used only with `experimental_on`. Release note: None **distsql: enhance testing columnar aggregator against processor** This commit adds an ability to insert NULL values into grouping columns and increases the number of grouping columns tested (previously it was hard-coded as one). ANY_NOT_NULL aggregate is now skipped since it returns non-deterministic output. This change required modifications to the test harness to allow the results of aggregation to deviate slightly when operating on float values because direct string matching will not work in some cases. Also, this commit extracts out arguments to the test harness into a separate struct. Release note: None 43288: ui: network latency page r=dhartunian a=elkmaster created new menu item for network latencies reports, redesign, added sort-by and filtering features Resolves: #43206 Release note (ui): none   44365: roachtest: adjust tpchvec test r=yuzefovich a=yuzefovich This commit adds the print out of all vec ON and vec OFF times if the test is failed because of slow vec ON performance. Also, in order to reduce noise, we now require that the best vec ON time is worse than the best vec OFF time. This addresses a case when a query has two fast runtimes and two slow ones (I don't know why it happens, but sometimes the first two runs of a query, especially with a small order number like Q3, will be slow with vec ON). Fixes: #44331. Release note: None Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: Vlad <carrott9@gmail.com> Co-authored-by: Vlad Los <carrott9@gmail.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the print out of all vec ON and vec OFF times if the
test is failed because of slow vec ON performance.
Also, in order to reduce noise, we now require that the best vec ON time
is worse than the best vec OFF time. This addresses a case when a query
has two fast runtimes and two slow ones (I don't know why it happens,
but sometimes the first two runs of a query, especially with a small
order number like Q3, will be slow with vec ON).
Fixes: #44331.
Release note: None