Skip to content

pgwire: deflake TestAuthenticationAndHBARules#43734

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20200106-deflake-auth-test
Jan 6, 2020
Merged

pgwire: deflake TestAuthenticationAndHBARules#43734
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20200106-deflake-auth-test

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Jan 6, 2020

Fixes #43733.

This was my mistake to fix, I had forgotten that cluster settings
propagate asynchronously.

Release note: None

This was my mistake to fix, I had forgotten that cluster settings
propagate asynchronously.

Release note: None
@knz knz requested a review from madelynnblue January 6, 2020 08:24
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@knz
Copy link
Copy Markdown
Contributor Author

knz commented Jan 6, 2020

thanks!

bors r+

craig bot pushed a commit that referenced this pull request Jan 6, 2020
43703: storage/batcheval/result: perform various cleanup on LocalResult struct r=nvanbenschoten a=nvanbenschoten

This PR contains a series of cleanups to the `result.LocalResult` struct. It leaves the structure in a good position to be extended to include information about newly written, updated, and removed intents, which are hooked into the `concurrency` package in future commits the same way that `UpdatedTxns` is currently hooked into the TxnWaitQueue.

The changes are broken into a series of incremental steps to make them easier to review in isolation.

43722: opt: fix assertion failure due to lax empty key r=RaduBerinde a=RaduBerinde

PR #43532 removed the concept of lax constant functional dependencies.
There is a left-over case when we downgrade a key: if we had a strong
empty key, the result is a lax empty key which is no longer a concept.

This change fixes this by removing the key altogether in this case.

Fixes #43651.

Release note (bug fix): fixes "expected constant FD to be strict"
internal error.

43734: pgwire: deflake TestAuthenticationAndHBARules r=knz a=knz

Fixes #43733.

This was my mistake to fix, I had forgotten that cluster settings
propagate asynchronously.

Release note: None

Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 6, 2020

Build succeeded

@craig craig bot merged commit 7a6de58 into cockroachdb:master Jan 6, 2020
craig bot pushed a commit that referenced this pull request Jan 8, 2020
43731: pgwire,hba: introduce the 'trust' and 'reject' auth methods r=knz a=knz

First commits from #43734 and #43726.

The 'trust' and 'reject' methods, as their name implies,
unconditionally allow and deny authentication of matching connections.

This patch introduces them as a prerequisite to later work on Unix
socket authentication, but also to introduce a bit of infrastructure
that binds new auth methods to a minimum required cluster
version. This new infrastructure ensures that future new auth methods
do not risk hosting a mixed-version cluster. (See discussion on #43717.)

The patch also introduces support for the 'local' rule prefix, which
is still unused.


Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pgwire: flake in TestAuthenticationAndHBARules

3 participants