storage/batcheval/result: perform various cleanup on LocalResult struct#43703
Merged
craig[bot] merged 6 commits intocockroachdb:masterfrom Jan 6, 2020
Merged
storage/batcheval/result: perform various cleanup on LocalResult struct#43703craig[bot] merged 6 commits intocockroachdb:masterfrom
craig[bot] merged 6 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
ajwerner
approved these changes
Jan 2, 2020
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 8 of 8 files at r2, 13 of 13 files at r3, 4 of 4 files at r4, 6 of 6 files at r5, 9 of 9 files at r6.
Reviewable status:complete! 1 of 0 LGTMs obtained
pkg/storage/intentresolver/intent_resolver.go, line 505 at r2 (raw file):
ctx context.Context, intents []roachpb.Intent, allowSyncProcessing bool, ) error { if len(intents) == 0 {
This seems like it could be a nice optimization. Do you have a sense of whether that case comes up?
nvb
commented
Jan 2, 2020
Contributor
Author
nvb
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/storage/intentresolver/intent_resolver.go, line 505 at r2 (raw file):
Previously, ajwerner wrote…
This seems like it could be a nice optimization. Do you have a sense of whether that case comes up?
I'm not sure whether it can come up. In fact, I don't think it currently does, but I wanted to keep the semantics that this method is a no-op (without launching any goroutines) if len(intents) == 0.
Release note: None
The Arg part of this was never used. Release note: None
Strictly a rename. Release note: None
Small refactor. Release note: None
Small refactor. Release note: None
This commit removes the pattern of storing pointers to slices in LocalResult so that it remains "comaprable". This isn't worth the complexity it creates, so this commit removes the pattern and stores slices directly in the struct. Release note: None
86639bd to
eadef77
Compare
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jan 6, 2020
43703: storage/batcheval/result: perform various cleanup on LocalResult struct r=nvanbenschoten a=nvanbenschoten This PR contains a series of cleanups to the `result.LocalResult` struct. It leaves the structure in a good position to be extended to include information about newly written, updated, and removed intents, which are hooked into the `concurrency` package in future commits the same way that `UpdatedTxns` is currently hooked into the TxnWaitQueue. The changes are broken into a series of incremental steps to make them easier to review in isolation. 43722: opt: fix assertion failure due to lax empty key r=RaduBerinde a=RaduBerinde PR #43532 removed the concept of lax constant functional dependencies. There is a left-over case when we downgrade a key: if we had a strong empty key, the result is a lax empty key which is no longer a concept. This change fixes this by removing the key altogether in this case. Fixes #43651. Release note (bug fix): fixes "expected constant FD to be strict" internal error. 43734: pgwire: deflake TestAuthenticationAndHBARules r=knz a=knz Fixes #43733. This was my mistake to fix, I had forgotten that cluster settings propagate asynchronously. Release note: None Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com> Co-authored-by: Radu Berinde <radu@cockroachlabs.com> Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Contributor
Build succeeded |
35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a series of cleanups to the
result.LocalResultstruct. It leaves the structure in a good position to be extended to include information about newly written, updated, and removed intents, which are hooked into theconcurrencypackage in future commits the same way thatUpdatedTxnsis currently hooked into the TxnWaitQueue.The changes are broken into a series of incremental steps to make them easier to review in isolation.