Skip to content

backup,import: remove sticky-bit conditional#41463

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
dt:always-stickybit
Oct 9, 2019
Merged

backup,import: remove sticky-bit conditional#41463
craig[bot] merged 1 commit intocockroachdb:masterfrom
dt:always-stickybit

Conversation

@dt
Copy link
Copy Markdown
Contributor

@dt dt commented Oct 9, 2019

Sticky-bit is always enabled in 20.1.

Release note: none.

Sticky-bit is always enabled in 20.1.

Release note: none.
@dt dt requested review from ajwerner and pbardea October 9, 2019 03:42
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@dt
Copy link
Copy Markdown
Contributor Author

dt commented Oct 9, 2019

bors r+

craig bot pushed a commit that referenced this pull request Oct 9, 2019
40696: changefeedccl: fix violation of CDC's ordering guarantees r=aayushshah15 a=aayushshah15

In cloudStorageSink, we currently name output files based on the earliest
timestamps inside those files. This can sometimes muddle the ordering
of output files, leading to a violation of CDC's ordering properties

This change fixes this violation by instead using the times of the 
last `EmitRow` and `EmitResolvedTimestamp` calls to order files. This ensures
that timestamps within the output files are consumed in the same order
that they're emitted in.

Fixes: #38368

Release justification: Fixes limitation of changefeeds when using cloud storage sinks.

Release note: None

41414: storage: treat non-voter replicas as suspect for replica GC r=ajwerner a=ajwerner

It is not clear that this is actually a problem but it seems like a good thing
to do. We can imagine cases where a replica is removed but never receives the
message which removes it from the range. In this case we could wait up to
10 days before removing the range. The VOTER_INCOMING case seems like even
less of a problem but there's not an obvious reason to be conservative here.

Release note: None

41419: cmd/roachtest: remove some duplication in ORM tests r=yuzefovich a=yuzefovich

We're running several ORM test suites, and each test contains the
copy-pasted logic for parsing the test output and summarizing it.
Now that logic is extracted into a couple of functions which
removes the duplication.

Release note: None

41463: backup,import: remove sticky-bit conditional r=dt a=dt

Sticky-bit is always enabled in 20.1.

Release note: none.

41472: importccl: add nullif option to DELIMITED r=spaskob a=spaskob

This is indeed when an input has a field that needs to
be treated as NULL. Example:
```
import table t022 (
a int, b string
) DELIMITED DATA ('nodelocal:///foo.csv') with nullif = '';
```
This will force all empty string fields to be inserted as
NULL in the table.

Release note (sql): add nullif option to IMPORT ... DELIMITED.

41474: sql: use errors.Is instead of direct error compares r=pbardea a=knz

As suggested in the error handling RFC.

Release justification: Fix to earlier fix for release.

Release note: None

Co-authored-by: Aayush Shah <aayush.shah15@gmail.com>
Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Co-authored-by: David Taylor <tinystatemachine@gmail.com>
Co-authored-by: Spas Bojanov <spas@cockroachlabs.com>
Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Oct 9, 2019

Build succeeded

@craig craig bot merged commit cd2ab65 into cockroachdb:master Oct 9, 2019
@dt dt deleted the always-stickybit branch October 9, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants