Skip to content

cmd/roachtest: remove some duplication in ORM tests#41419

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
yuzefovich:gopg
Oct 9, 2019
Merged

cmd/roachtest: remove some duplication in ORM tests#41419
craig[bot] merged 1 commit intocockroachdb:masterfrom
yuzefovich:gopg

Conversation

@yuzefovich
Copy link
Copy Markdown
Member

We're running several ORM test suites, and each test contains the
copy-pasted logic for parsing the test output and summarizing it.
Now that logic is extracted into a couple of functions which
removes the duplication.

Release note: None

We're running several ORM test suites, and each test contains the
copy-pasted logic for parsing the test output and summarizing it.
Now that logic is extracted into a couple of functions which
removes the duplication.

Release note: None
@yuzefovich yuzefovich requested review from a team, jordanlewis and rafiss October 7, 2019 22:52
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@rohany
Copy link
Copy Markdown
Contributor

rohany commented Oct 8, 2019

I'm not too familiar with the code here yet, but I'd like to see this merged -- adding a new test for django is going to result in needing to duplicate all this code again.

Copy link
Copy Markdown
Contributor

@rohany rohany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis and @rafiss)

@yuzefovich
Copy link
Copy Markdown
Member Author

TFTR!

bors r+

craig bot pushed a commit that referenced this pull request Oct 9, 2019
40696: changefeedccl: fix violation of CDC's ordering guarantees r=aayushshah15 a=aayushshah15

In cloudStorageSink, we currently name output files based on the earliest
timestamps inside those files. This can sometimes muddle the ordering
of output files, leading to a violation of CDC's ordering properties

This change fixes this violation by instead using the times of the 
last `EmitRow` and `EmitResolvedTimestamp` calls to order files. This ensures
that timestamps within the output files are consumed in the same order
that they're emitted in.

Fixes: #38368

Release justification: Fixes limitation of changefeeds when using cloud storage sinks.

Release note: None

41414: storage: treat non-voter replicas as suspect for replica GC r=ajwerner a=ajwerner

It is not clear that this is actually a problem but it seems like a good thing
to do. We can imagine cases where a replica is removed but never receives the
message which removes it from the range. In this case we could wait up to
10 days before removing the range. The VOTER_INCOMING case seems like even
less of a problem but there's not an obvious reason to be conservative here.

Release note: None

41419: cmd/roachtest: remove some duplication in ORM tests r=yuzefovich a=yuzefovich

We're running several ORM test suites, and each test contains the
copy-pasted logic for parsing the test output and summarizing it.
Now that logic is extracted into a couple of functions which
removes the duplication.

Release note: None

41463: backup,import: remove sticky-bit conditional r=dt a=dt

Sticky-bit is always enabled in 20.1.

Release note: none.

41472: importccl: add nullif option to DELIMITED r=spaskob a=spaskob

This is indeed when an input has a field that needs to
be treated as NULL. Example:
```
import table t022 (
a int, b string
) DELIMITED DATA ('nodelocal:///foo.csv') with nullif = '';
```
This will force all empty string fields to be inserted as
NULL in the table.

Release note (sql): add nullif option to IMPORT ... DELIMITED.

41474: sql: use errors.Is instead of direct error compares r=pbardea a=knz

As suggested in the error handling RFC.

Release justification: Fix to earlier fix for release.

Release note: None

Co-authored-by: Aayush Shah <aayush.shah15@gmail.com>
Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Co-authored-by: David Taylor <tinystatemachine@gmail.com>
Co-authored-by: Spas Bojanov <spas@cockroachlabs.com>
Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Oct 9, 2019

Build succeeded

@craig craig bot merged commit 49e0a1e into cockroachdb:master Oct 9, 2019
@yuzefovich yuzefovich deleted the gopg branch November 12, 2019 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants