Merged
Conversation
Member
b25b5ef to
1d010fc
Compare
Release note: none Release justification: no code changes
1d010fc to
2b56889
Compare
dt
approved these changes
Sep 26, 2019
Contributor
Author
|
bors r+ |
Contributor
Build failed |
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 26, 2019
41098: roachtest/jepsen: don't fail test if retrieving invoke.log fails r=nvanbenschoten a=nvanbenschoten Fixes #41062. Release justification: Testing only. Release note: None 41104: kv: check for 1-phase commit after request, not before r=nvanbenschoten a=nvanbenschoten Found while verifying that #40518 didn't negatively impact YCSB performance. As it turns out, most txns that restart hit the check in DistSender instead, and that ends up being critical for forward progress. Without it, transactions appear to starve because they never write intents. The commit doesn't make any changes there, but it does fix an issue where 1PC transactions were being incorrectly detected. The detection was ignoring the fact that a 1PC attempt could be rejected by DistSender or a Replica. We now tie the metric to whether an EndTransaction actually evaluated as a 1PC txn instead of tying it to whether the EndTransaction _wanted_ to be evaluated as a 1PC txn. Release justification: low risk and improves metric reporting Release note: None 41127: Add myself to AUTHORS r=miretskiy a=miretskiy Authors += Myself Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com> Co-authored-by: Yevgeniy Miretskiy <yevgeniy@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authors += Myself