Skip to content

roachtest/jepsen: don't fail test if retrieving invoke.log fails#41098

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/jepsenFlake2
Sep 26, 2019
Merged

roachtest/jepsen: don't fail test if retrieving invoke.log fails#41098
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/jepsenFlake2

Conversation

@nvb
Copy link
Copy Markdown
Contributor

@nvb nvb commented Sep 25, 2019

Fixes #41062.

Release justification: Testing only.

Release note: None

Fixes cockroachdb#41062.

Release justification: Testing only.

Release note: None
@nvb nvb requested a review from bdarnell September 25, 2019 23:06
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@nvb
Copy link
Copy Markdown
Contributor Author

nvb commented Sep 26, 2019

bors r+

craig bot pushed a commit that referenced this pull request Sep 26, 2019
41098: roachtest/jepsen: don't fail test if retrieving invoke.log fails r=nvanbenschoten a=nvanbenschoten

Fixes #41062.

Release justification: Testing only.

Release note: None

41104: kv: check for 1-phase commit after request, not before r=nvanbenschoten a=nvanbenschoten

Found while verifying that #40518 didn't negatively impact YCSB performance.
As it turns out, most txns that restart hit the check in DistSender instead,
and that ends up being critical for forward progress. Without it, transactions
appear to starve because they never write intents.

The commit doesn't make any changes there, but it does fix an issue where
1PC transactions were being incorrectly detected. The detection was ignoring
the fact that a 1PC attempt could be rejected by DistSender or a Replica.
We now tie the metric to whether an EndTransaction actually evaluated as
a 1PC txn instead of tying it to whether the EndTransaction _wanted_ to
be evaluated as a 1PC txn.

Release justification: low risk and improves metric reporting

Release note: None

41127: Add myself to AUTHORS r=miretskiy a=miretskiy

Authors += Myself

Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Co-authored-by: Yevgeniy Miretskiy <yevgeniy@cockroachlabs.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 26, 2019

Build succeeded

@craig craig bot merged commit 2662f48 into cockroachdb:master Sep 26, 2019
@nvb nvb deleted the nvanbenschoten/jepsenFlake2 branch October 14, 2019 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

roachtest: jepsen/sequential/parts-start-kill-2 failed

3 participants