storage: deflake TestSnapshotAfterTruncationWithUncommittedTail#37105
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Apr 25, 2019
Merged
storage: deflake TestSnapshotAfterTruncationWithUncommittedTail#37105craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
…ithUncommittedTail This avoids unnecessary NotLeaseHolderErrors when we don't need to enforce which replica can evaluate a request. We see that in the current CI failure in cockroachdb#37093. Release note: None
Fixes cockroachdb#37085. This filtering was assuming that the Raft message's index field indicated the first index in the MsgApp. It actually indicates the log index that _precedes_ any of the entries in the MsgApp. It stole this from TestReplicaRangefeedRetryErrors, so the commit updates that too. Release note: None
Member
|
This change is |
ajwerner
approved these changes
Apr 24, 2019
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Nice find
Reviewed 1 of 1 files at r1, 2 of 2 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 25, 2019
37105: storage: deflake TestSnapshotAfterTruncationWithUncommittedTail r=nvanbenschoten a=nvanbenschoten Fixes #37085. This PR fixes two flakes in TestSnapshotAfterTruncationWithUncommittedTail. The first has to do with unexpected NotLeaseHolderErrors and the second has to do with a stall that was possible due to incorrect filtering of `MsgApp`s. Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37085.
This PR fixes two flakes in TestSnapshotAfterTruncationWithUncommittedTail. The first has to do with unexpected NotLeaseHolderErrors and the second has to do with a stall that was possible due to incorrect filtering of
MsgApps.