release-19.1: storage: create new TestSnapshotAfterTruncationWithUncommittedTail test#37093
Merged
nvb merged 5 commits intocockroachdb:release-19.1from Apr 29, 2019
Merged
Conversation
Release note: None
This PR adds a regression test for cockroachdb#37056. In doing so, it also confirms the theory that cockroachdb#37055 is the proper fix for that bug. Before cockroachdb#37055, the test would get stuck with the following logs repeatedly firing: ``` I190424 00:15:52.338808 12 storage/client_test.go:1242 SucceedsSoon: expected [21 21 21], got [12 21 21] I190424 00:15:52.378060 78 vendor/go.etcd.io/etcd/raft/raft.go:1317 [s1,r1/1:/M{in-ax}] 1 [logterm: 6, index: 31] rejected msgApp [logterm: 8, index: 31] from 2 I190424 00:15:52.378248 184 vendor/go.etcd.io/etcd/raft/raft.go:1065 [s2,r1/2:/M{in-ax}] 2 received msgApp rejection(lastindex: 31) from 1 for index 31 I190424 00:15:52.378275 184 vendor/go.etcd.io/etcd/raft/raft.go:1068 [s2,r1/2:/M{in-ax}] 2 decreased progress of 1 to [next = 31, match = 31, state = ProgressStateProbe, waiting = false, pendingSnapshot = 0] ``` After cockroachdb#37055, the test passes. Release note: None
This commit speeds up the test added in cockroachdb#37058 by parallelizing its failed writes. Release note: None
Member
ajwerner
approved these changes
Apr 24, 2019
nvb
added a commit
to nvb/cockroach
that referenced
this pull request
Apr 24, 2019
…ithUncommittedTail This avoids unnecessary NotLeaseHolderErrors when we don't need to enforce which replica can evaluate a request. We see that in the current CI failure in cockroachdb#37093. Release note: None
…ithUncommittedTail This avoids unnecessary NotLeaseHolderErrors when we don't need to enforce which replica can evaluate a request. We see that in the current CI failure in cockroachdb#37093. Release note: None
Fixes cockroachdb#37085. This filtering was assuming that the Raft message's index field indicated the first index in the MsgApp. It actually indicates the log index that _precedes_ any of the entries in the MsgApp. It stole this from TestReplicaRangefeedRetryErrors, so the commit updates that too. Release note: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport:
Please see individual PRs for details.
/cc @cockroachdb/release