Skip to content

release-19.1: storage: create new TestSnapshotAfterTruncationWithUncommittedTail test#37093

Merged
nvb merged 5 commits intocockroachdb:release-19.1from
nvb:backport19.1-37058-37079
Apr 29, 2019
Merged

release-19.1: storage: create new TestSnapshotAfterTruncationWithUncommittedTail test#37093
nvb merged 5 commits intocockroachdb:release-19.1from
nvb:backport19.1-37058-37079

Conversation

@nvb
Copy link
Copy Markdown
Contributor

@nvb nvb commented Apr 24, 2019

Backport:

Please see individual PRs for details.

/cc @cockroachdb/release

nvb added 3 commits April 24, 2019 16:24
This PR adds a regression test for cockroachdb#37056. In doing so, it also confirms
the theory that cockroachdb#37055 is the proper fix for that bug.

Before cockroachdb#37055, the test would get stuck with the following logs repeatedly
firing:
```
I190424 00:15:52.338808 12 storage/client_test.go:1242  SucceedsSoon: expected [21 21 21], got [12 21 21]
I190424 00:15:52.378060 78 vendor/go.etcd.io/etcd/raft/raft.go:1317  [s1,r1/1:/M{in-ax}] 1 [logterm: 6, index: 31] rejected msgApp [logterm: 8, index: 31] from 2
I190424 00:15:52.378248 184 vendor/go.etcd.io/etcd/raft/raft.go:1065  [s2,r1/2:/M{in-ax}] 2 received msgApp rejection(lastindex: 31) from 1 for index 31
I190424 00:15:52.378275 184 vendor/go.etcd.io/etcd/raft/raft.go:1068  [s2,r1/2:/M{in-ax}] 2 decreased progress of 1 to [next = 31, match = 31, state = ProgressStateProbe, waiting = false, pendingSnapshot = 0]
```

After cockroachdb#37055, the test passes.

Release note: None
This commit speeds up the test added in cockroachdb#37058 by parallelizing its
failed writes.

Release note: None
@nvb nvb requested review from a team and ajwerner April 24, 2019 20:24
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

nvb added a commit to nvb/cockroach that referenced this pull request Apr 24, 2019
…ithUncommittedTail

This avoids unnecessary NotLeaseHolderErrors when we don't need to enforce
which replica can evaluate a request. We see that in the current CI failure
in cockroachdb#37093.

Release note: None
nvb added 2 commits April 25, 2019 14:13
…ithUncommittedTail

This avoids unnecessary NotLeaseHolderErrors when we don't need to enforce
which replica can evaluate a request. We see that in the current CI failure
in cockroachdb#37093.

Release note: None
Fixes cockroachdb#37085.

This filtering was assuming that the Raft message's index field
indicated the first index in the MsgApp. It actually indicates the
log index that _precedes_ any of the entries in the MsgApp.

It stole this from TestReplicaRangefeedRetryErrors, so the commit
updates that too.

Release note: None
@nvb nvb merged commit 73765b6 into cockroachdb:release-19.1 Apr 29, 2019
@nvb nvb deleted the backport19.1-37058-37079 branch April 29, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants