Skip to content

storage: speed up TestSnapshotAfterTruncationWithUncommittedTail#37079

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/fasterTest
Apr 24, 2019
Merged

storage: speed up TestSnapshotAfterTruncationWithUncommittedTail#37079
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/fasterTest

Conversation

@nvb
Copy link
Copy Markdown
Contributor

@nvb nvb commented Apr 24, 2019

This commit speeds up the test added in #37058 by parallelizing its
failed writes.

Release note: None

This commit speeds up the test added in cockroachdb#37058 by parallelizing its
failed writes.

Release note: None
@nvb nvb requested review from a team and ajwerner April 24, 2019 15:01
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@nvb
Copy link
Copy Markdown
Contributor Author

nvb commented Apr 24, 2019

bors r+

craig bot pushed a commit that referenced this pull request Apr 24, 2019
37079: storage: speed up TestSnapshotAfterTruncationWithUncommittedTail r=nvanbenschoten a=nvanbenschoten

This commit speeds up the test added in #37058 by parallelizing its
failed writes.

Release note: None

Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 24, 2019

Build succeeded

@craig craig bot merged commit 8aa5d1a into cockroachdb:master Apr 24, 2019
@nvb nvb deleted the nvanbenschoten/fasterTest branch April 24, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants