Skip to content

sql: fix catch context deadline exceeded error in schema changer#35851

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
vivekmenezes:dropwhilebackfill
Mar 18, 2019
Merged

sql: fix catch context deadline exceeded error in schema changer#35851
craig[bot] merged 1 commit intocockroachdb:masterfrom
vivekmenezes:dropwhilebackfill

Conversation

@vivekmenezes
Copy link
Copy Markdown
Contributor

@vivekmenezes vivekmenezes commented Mar 18, 2019

this is a fix for change #35731

fixes #35743
fixes #35782

Release note: None

@vivekmenezes vivekmenezes requested review from a team and knz March 18, 2019 12:51
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@vivekmenezes
Copy link
Copy Markdown
Contributor Author

bors r+

craig bot pushed a commit that referenced this pull request Mar 18, 2019
35851: sql: fix catch context deadline exceeded error in schema changer r=vivekmenezes a=vivekmenezes

this is a fix for change #35731

fixes #35743 
fixes #35782 

Release note: None

Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 18, 2019

Build succeeded

@craig craig bot merged commit b8416c3 into cockroachdb:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql: TestDropWhileBackfill failed under stress teamcity: failed test: TestDropWhileBackfill

3 participants