*: avoid direct uses of pgerror.CodeInternalError#35731
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 14, 2019
Merged
*: avoid direct uses of pgerror.CodeInternalError#35731craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
This patch ensures that internal errors / assertion failures are instantiated with `pgerror.NewAssertionErrorf` (with a linter to also enforce in the future). This is in advance of equipping the constructor with a stack trace collection service. Release note: None
jordanlewis
approved these changes
Mar 14, 2019
Contributor
Author
|
TFYR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Mar 14, 2019
35731: *: avoid direct uses of pgerror.CodeInternalError r=knz a=knz This patch ensures that internal errors / assertion failures are instantiated with `pgerror.NewAssertionErrorf` (with a linter to also enforce in the future). This is in advance of equipping the constructor with a stack trace collection service. Release note: None Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Contributor
Build succeeded |
vivekmenezes
added a commit
to vivekmenezes/cockroach
that referenced
this pull request
Mar 18, 2019
this is a fix for change cockroachdb#35731 Release note: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch ensures that internal errors / assertion failures are
instantiated with
pgerror.NewAssertionErrorf(with a linter to alsoenforce in the future).
This is in advance of equipping the constructor with a stack trace
collection service.
Release note: None