ui: remove monospace font for human-readable job description#35652
ui: remove monospace font for human-readable job description#35652craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @celiala, @RaduBerinde, @rytaft, and @vilterp)
pkg/ui/src/views/jobs/index.tsx, line 202 at r2 (raw file):
title: "Description", cell: job => { if (job.type === jobTypeAutoCreateStats) {
I think the more general thing to check is if job.statement is not empty (when the field is empty, the description is the statement).
celiala
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ui/src/views/jobs/index.tsx, line 202 at r2 (raw file):
Previously, RaduBerinde wrote…
I think the more general thing to check is if job.statement is not empty (when the field is empty, the description is the statement).
ah, thanks - will do!
|
TFTR! bors r+ |
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ui/src/views/jobs/index.tsx, line 202 at r2 (raw file):
Previously, celiala wrote…
ah, thanks - will do!
[nit] probably a good idea to leave a comment explaining this
|
bors r- |
Canceled |
|
oh wait, I think that cancels everybody's -- will fix the nit in a future commit bors r;-bors r+ |
In cockroachdb#35439, we introduced a user-friendly message (instead of the exact SQL statement) for automatic table stats. This commit uses the default font for that message, reserving the monospace font for just SQL text. Release note: None
|
TFTRs!
bors r+ |
35607: roachtest: Renenable SQLSmith roachtest r=BramGruneir a=BramGruneir Note that this is the original roachtest and not the re-written one. If we find that this one does not find any different issues, we should remove it entirely. But there is no harm in enabling it right now. Release note: None 35623: storage: enable follower_reads by default r=ajwerner a=ajwerner This PR enables storage level follower reads by default. Follower reads still will not be used for request routing without an enterprise license. Release note: None 35645: sql/sqlbase: fix TestEncDatumSize under go1.12 r=knz a=petermattis Fixes #35636. golang/go@bfc54bb reduced the memory usage of small big integers which in turn reduced the `EncDatum.Size()` for the decimal datum used in this test. Release note: None 35652: ui: remove monospace font for human-readable job description r=celiala a=celiala In #35439, we introduced a user-friendly message (instead of the exact SQL statement) for automatic table stats. This commit uses the default font for that message, reserving the monospace font for just SQL text. cc @rolandcrosby @piyush-singh  35654: roachtest: two easy changefeed test fixes r=nvanbenschoten a=danhhz See commits for details Co-authored-by: Bram Gruneir <bram@cockroachlabs.com> Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com> Co-authored-by: Peter Mattis <petermattis@gmail.com> Co-authored-by: Celia La <celia@cockroachlabs.com> Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com>
Build succeeded |
In #35439, we introduced a user-friendly message (instead of the
exact SQL statement) for automatic table stats.
This commit uses the default font for that message, reserving
the monospace font for just SQL text.
cc @rolandcrosby @piyush-singh