sql/sqlbase: fix TestEncDatumSize under go1.12#35645
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 12, 2019
Merged
sql/sqlbase: fix TestEncDatumSize under go1.12#35645craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
|
LGTM, thanks! |
golang/go@bfc54bb reduced the memory usage of small big integers which in turn reduced the `EncDatum.Size()` for the decimal datum used in this test. Release note: None
e67dc8b to
94c1936
Compare
Collaborator
Author
|
bors r=knz |
craig bot
pushed a commit
that referenced
this pull request
Mar 12, 2019
35607: roachtest: Renenable SQLSmith roachtest r=BramGruneir a=BramGruneir Note that this is the original roachtest and not the re-written one. If we find that this one does not find any different issues, we should remove it entirely. But there is no harm in enabling it right now. Release note: None 35623: storage: enable follower_reads by default r=ajwerner a=ajwerner This PR enables storage level follower reads by default. Follower reads still will not be used for request routing without an enterprise license. Release note: None 35645: sql/sqlbase: fix TestEncDatumSize under go1.12 r=knz a=petermattis Fixes #35636. golang/go@bfc54bb reduced the memory usage of small big integers which in turn reduced the `EncDatum.Size()` for the decimal datum used in this test. Release note: None 35652: ui: remove monospace font for human-readable job description r=celiala a=celiala In #35439, we introduced a user-friendly message (instead of the exact SQL statement) for automatic table stats. This commit uses the default font for that message, reserving the monospace font for just SQL text. cc @rolandcrosby @piyush-singh  35654: roachtest: two easy changefeed test fixes r=nvanbenschoten a=danhhz See commits for details Co-authored-by: Bram Gruneir <bram@cockroachlabs.com> Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com> Co-authored-by: Peter Mattis <petermattis@gmail.com> Co-authored-by: Celia La <celia@cockroachlabs.com> Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35636.
golang/go@bfc54bb
reduced the memory usage of small big integers which in turn reduced the
EncDatum.Size()for the decimal datum used in this test.Release note: None