sql: tolerate non-existent databases for plan cache invalidation#35151
sql: tolerate non-existent databases for plan cache invalidation#35151craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis, @knz, and @RaduBerinde)
pkg/sql/logictest/testdata/logic_test/prepare, line 960 at r1 (raw file):
subtest regression_35145 # Verify db-independent query returns valid results even when db does not exist
[nit] s/valid results even/the expected error/ ?
pkg/sql/logictest/testdata/logic_test/prepare, line 974 at r1 (raw file):
statement ok CREATE DATABASE d35145; SET database = d35145; DROP DATABASE d35145
A little confused by this test - is there a reason we don't prepare the statement inside this db?
585b433 to
1064580
Compare
knz
left a comment
There was a problem hiding this comment.
RFAL
Reviewable status:
pkg/sql/logictest/testdata/logic_test/prepare, line 960 at r1 (raw file):
Previously, RaduBerinde wrote…
[nit] s/valid results even/the expected error/ ?
Yep, thanks.
pkg/sql/logictest/testdata/logic_test/prepare, line 974 at r1 (raw file):
Previously, RaduBerinde wrote…
A little confused by this test - is there a reason we don't prepare the statement inside this db?
Your question makes me realize there are two relevant cases for the test. Clarified.
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/sql/logictest/testdata/logic_test/prepare, line 978 at r2 (raw file):
ap35145 subtest regression_35145_prepared_db_disappears
It doesn't look like this subtest would function separately of the statements above. I'd replace this with a comment. Same below.
Release note (bug fix): CockroachDB again properly reports when a database used during PREPARE does not exist any more when EXECUTE is used.
1064580 to
f069ca9
Compare
knz
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/sql/logictest/testdata/logic_test/prepare, line 978 at r2 (raw file):
Previously, RaduBerinde wrote…
It doesn't look like this subtest would function separately of the statements above. I'd replace this with a comment. Same below.
Done.
|
TFYR! bors r+ |
Build failed |
|
bors r+ |
Build failed (retrying...) |
|
bors r+ |
|
Not awaiting review |
|
bors r- |
Canceled |
|
bors r+ |
35077: workload: add indexes workload r=nvanbenschoten a=nvanbenschoten Closes #34912. This adds a new workload called `indexes`. Unlike `kv`, the workload is specifically designed to stress secondary indexes. Its schema looks like: ``` CREATE TABLE indexes ( key UUID NOT NULL PRIMARY KEY, col0 INT NOT NULL, col1 INT NOT NULL, col2 INT NOT NULL, col3 INT NOT NULL, col4 INT NOT NULL, col5 INT NOT NULL, col6 INT NOT NULL, col7 INT NOT NULL, col8 INT NOT NULL, col9 INT NOT NULL, payload BYTES NOT NULL ) ``` and it includes knobs to specify how many of the "col" columns should be indexed and whether they should be indexed using a UNIQUE specifier. The workload also includes a knob to specify the size of the `payload` column. Release note: None 35116: sql: add support for extra session vars for pg compatibility r=knz a=knz Fixes #35109. This adds compatibility support for the following variables, with only the default values that make sense in CockroachDB: - `row_security` - `synchronize_seqscans`, - `lock_timeout`, - `idle_in_transaction_session_timeout` Release note: None 35134: storageccl: leave params in workload URIs r=dt a=dt workload URIs do not contain anything sensitive and including them in the job make it easier see what it was actually doing. Release note: none. 35151: sql: tolerate non-existent databases for plan cache invalidation r=knz a=knz Fixes #35145. Release note (bug fix): CockroachDB again properly reports when a database used during PREPARE does not exist any more when EXECUTE is used. 35162: storage: remove TODOs in cmd_push_txn r=nvanbenschoten a=nvanbenschoten This was discussed in #33523 (review) but I missed digging into it at the time. I still don't think I have my head fully wrapped around it, but I do enough to know that it's not something I want to start pulling on right now. Release note: None Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com> Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com> Co-authored-by: David Taylor <tinystatemachine@gmail.com>
Build succeeded |
Fixes #35145.
Release note (bug fix): CockroachDB again properly reports when a
database used during PREPARE does not exist any more when EXECUTE is
used.