Skip to content

storageccl: leave params in workload URIs#35134

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
dt:workload-uri
Feb 25, 2019
Merged

storageccl: leave params in workload URIs#35134
craig[bot] merged 1 commit intocockroachdb:masterfrom
dt:workload-uri

Conversation

@dt
Copy link
Copy Markdown
Contributor

@dt dt commented Feb 21, 2019

workload URIs do not contain anything sensitive and including them in the job make it easier see what it was actually doing.

Release note: none.

workload URIs do not contain anything sensitive and including them in the job make it easier see what it was actually doing.

Release note: none.
@dt dt requested review from a team and danhhz February 21, 2019 20:41
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@dt
Copy link
Copy Markdown
Contributor Author

dt commented Feb 25, 2019

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 25, 2019

Build failed (retrying...)

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 25, 2019

Build failed (retrying...)

@dt
Copy link
Copy Markdown
Contributor Author

dt commented Feb 25, 2019

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 25, 2019

Not awaiting review

@dt
Copy link
Copy Markdown
Contributor Author

dt commented Feb 25, 2019

bors retry

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 25, 2019

Not awaiting review

@dt
Copy link
Copy Markdown
Contributor Author

dt commented Feb 25, 2019

bors r-

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 25, 2019

Canceled

@dt
Copy link
Copy Markdown
Contributor Author

dt commented Feb 25, 2019

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 25, 2019

Build failed (retrying...)

craig bot pushed a commit that referenced this pull request Feb 25, 2019
35077: workload: add indexes workload r=nvanbenschoten a=nvanbenschoten

Closes #34912.

This adds a new workload called `indexes`. Unlike `kv`, the workload is
specifically designed to stress secondary indexes. Its schema looks
like:

```
CREATE TABLE indexes (
    key     UUID  NOT NULL PRIMARY KEY,
    col0    INT   NOT NULL,
    col1    INT   NOT NULL,
    col2    INT   NOT NULL,
    col3    INT   NOT NULL,
    col4    INT   NOT NULL,
    col5    INT   NOT NULL,
    col6    INT   NOT NULL,
    col7    INT   NOT NULL,
    col8    INT   NOT NULL,
    col9    INT   NOT NULL,
    payload BYTES NOT NULL
)
```

and it includes knobs to specify how many of the "col" columns should be
indexed and whether they should be indexed using a UNIQUE specifier. The
workload also includes a knob to specify the size of the `payload`
column.

Release note: None

35116: sql: add support for extra session vars for pg compatibility r=knz a=knz

Fixes #35109.

This adds compatibility support for the following variables, with only
the default values that make sense in CockroachDB:

- `row_security`
- `synchronize_seqscans`,
- `lock_timeout`,
- `idle_in_transaction_session_timeout`

Release note: None

35134: storageccl: leave params in workload URIs r=dt a=dt

workload URIs do not contain anything sensitive and including them in the job make it easier see what it was actually doing.

Release note: none.

35151: sql: tolerate non-existent databases for plan cache invalidation r=knz a=knz

Fixes  #35145.

Release note (bug fix): CockroachDB again properly reports when a
database used during PREPARE does not exist any more when EXECUTE is
used.

35162: storage: remove TODOs in cmd_push_txn r=nvanbenschoten a=nvanbenschoten

This was discussed in #33523 (review) but I missed digging into it at the time. I still don't think I have my head fully wrapped around it, but I do enough to know that it's not something I want to start pulling on right now.

Release note: None

Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Co-authored-by: David Taylor <tinystatemachine@gmail.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 25, 2019

Build succeeded

@craig craig bot merged commit f62466c into cockroachdb:master Feb 25, 2019
@dt dt deleted the workload-uri branch February 25, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants